[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#603486: marked as done (Upload permission and future unblock: gphoto2/2.4.5-3)

Your message dated Sun, 14 Nov 2010 18:57:13 +0000
with message-id <1289761033.13259.455.camel@hathi.jungle.funky-badger.org>
and subject line Re: Bug#603486: Upload permission and future unblock: gphoto2/2.4.5-3
has caused the Debian Bug report #603486,
regarding Upload permission and future unblock: gphoto2/2.4.5-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
603486: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603486
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Dear RT,
am I allowed to upload a package with the following debdiff? It fixes #512883
(which is RC).

Thank you,
David

-- 
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://deb.li/dapal
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

diff --git a/debian/changelog b/debian/changelog
index 9c76be8..79b1f32 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+gphoto2 (2.4.5-3) unstable; urgency=low
+
+  * Warn and exit with an error if files couldn't be written to
+    disk (Closes: #512883)
+  * Added myself to Uploaders
+
+ -- David Paleino <dapal@debian.org>  Sun, 14 Nov 2010 17:14:36 +0100
+
 gphoto2 (2.4.5-2) unstable; urgency=low
 
   * debian/control:
diff --git a/debian/control b/debian/control
index 9043ec4..f7e69ad 100644
--- a/debian/control
+++ b/debian/control
@@ -3,6 +3,7 @@ Section: utils
 Priority: extra
 Maintainer: Debian PhotoTools Maintainers <pkg-phototools-devel@lists.alioth.debian.org>
 Uploaders: Frederic Peters <fpeters@debian.org>, Cyril Brulebois <kibi@debian.org>
+ , David Paleino <dapal@debian.org>
 Build-Depends: debhelper (>= 7),
                quilt,
                type-handling (>= 0.2.1),
diff --git a/debian/patches/01-handle_EACCES.patch b/debian/patches/01-handle_EACCES.patch
new file mode 100644
index 0000000..c5e5492
--- /dev/null
+++ b/debian/patches/01-handle_EACCES.patch
@@ -0,0 +1,31 @@
+From: David Paleino <dapal@debian.org>
+Subject: exit with an error if files couldn't be written to disk
+Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512883
+Origin: vendor
+Forwarded: yes, https://sourceforge.net/tracker/index.php?func=detail&aid=3109145&group_id=8874&atid=308874
+
+---
+ gphoto2/main.c |    5 +++++
+ 1 file changed, 5 insertions(+)
+
+--- gphoto2-2.4.5.orig/gphoto2/main.c
++++ gphoto2-2.4.5/gphoto2/main.c
+@@ -43,6 +43,7 @@
+ #include <fcntl.h>
+ #include <utime.h>
+ #include <limits.h>
++#include <errno.h>
+ 
+ #ifdef HAVE_POPT
+ #  include <popt.h>
+@@ -501,6 +502,10 @@ save_file_to_file (Camera *camera, GPCon
+ 	strcpy (tmpname, "tmpfileXXXXXX");
+ 	fd = mkstemp(tmpname);
+ 	if (fd == -1) {
++	    if (errno == EACCES) {
++	        gp_context_error (context, _("Permission denied"));
++	        return GP_ERROR;
++	    }
+         	CR (gp_file_new (&file));
+ 		tmpfilename = NULL;
+ 	} else {
diff --git a/debian/patches/series b/debian/patches/series
index 1d77bb1..e4ef4ce 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
+01-handle_EACCES.patch
 20_german_translation

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
On Sun, 2010-11-14 at 19:17 +0100, David Paleino wrote:
> On Sun, 14 Nov 2010 17:40:26 +0000, Adam D. Barratt wrote:
> 
> > On Sun, 2010-11-14 at 17:33 +0100, David Paleino wrote:
> > > am I allowed to upload a package with the following debdiff? It fixes
> > > #512883 (which is RC).
> > 
> > Please go ahead.
> 
> Uploaded :)

Unblocked.

Regards,

Adam

--- End Message ---
Reply to: