Hi, The Pioneers upstream have released 0.12.3.1 (0.12.3-1 is in squeeze now). They call it a "translation update", which is the major part of it. However, it also contains a few code changes to make it use gtk+ 2.20. I listed the changes below. The upstream changelog entry is: +2010-09-26 Roland Clobus <rclobus@rclobus.nl> * configure.ac: Release 0.12.3.1 * common/gtk/gtkbugs.c, common/gtk/guimap.c, client/gtk/histogram.c: Build with Gtk+-2.20 * client/gtk/monopoly.c, client/common/player.c: Use en_US * client/gtk/data/themes/Wesnoth-like/theme.cfg, client/gtk/data/themes/Freeciv-like/theme.cfg: Fix themes * Released 0.12.3.1 (Translation update) My question is: what should I do? I want at least the translations to go in squeeze; the theme fixes are colors; I think it should be fine to let them in as well. Is it ok to just package the new version and include the gtk stuff as well? Or should I put the translations in a patch and release them as 0.12.3-2? Is it ok to include the color fixes also in that case? Thanks, Bas Wijnen (packager for pioneers) - if (histogram_dlg && GTK_WIDGET_VISIBLE(histogram_dlg)) + if (histogram_dlg) - gtk_widget_destroyed(widget, arg); gtk_widget_destroyed(histogram_area, &histogram_area); + gtk_widget_destroyed(widget, arg); +#if (GTK_MAJOR_VERSION <= 2 && GTK_MINOR_VERSION <= 18 && GTK_MICRO_VERSION < 2) GtkWidget *button; +#endif gtk_widget_set_sensitive(widget, sensitive); +#if (GTK_MAJOR_VERSION <= 2 && GTK_MINOR_VERSION <= 18 && GTK_MICRO_VERSION < 2) /** @bug Gtk bug 56070. If the mouse is over a toolbar button that * becomes sensitive, one can't click it without moving the mouse out * and in again. This bug is registered in Bugzilla as a Gtk bug. The * workaround tests if the mouse is inside the currently sensitivized * button, and if yes call button_enter() + * + * Fixed in Gtk 2.18.2 */ if (!GTK_IS_BIN(widget)) return; @@ -88,6 +93,7 @@ void widget_set_sensitive(GtkWidget * wi gtk_widget_set_state(widget, GTK_STATE_PRELIGHT); } } +#endif - area->style->fg_gc[GTK_WIDGET_STATE(area)], + area->style->fg_gc[GTK_STATE_NORMAL],
Attachment:
signature.asc
Description: OpenPGP digital signature