[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

unblock request for iputils 20100418-3

Hello.  Bug 585591 renders iputils-arping pretty much useless.  I just
uploaded version 3:20100418-3 to unstable to address this issue.  The
patch, which has also been incorporated upstream, is straightforward.
It is attached for review.  Please allow this package into squeeze.


From: Paul Martin <pm@debian.org>
Date: Thu, 16 Sep 2010 08:19:44 +0000 (+0900)
Subject: arping: Set correct broadcast address.
X-Git-Tag: s20101006~4
X-Git-Url: http://www.linux-ipv6.org/gitweb/gitweb.cgi?p=gitroot%2Fiputils.git;a=commitdiff_plain;h=c5ccadd1f5251400d7f8382cd39f45e68940033c

arping: Set correct broadcast address.

There seems to have been introduced a bug in iputils release s20100418.

This patch is based upon git://www.linux-ipv6.org/gitroot/iputils.git
(git commit fe342ca3148)

The regression is caused by commit 56018bf1b3
 arping: Support link-layer type with larger link-layer address.

As reported by: Paul Martin <pm@debian.org> in Debian bugreport #585591.

 There's a logic error in the function that parses the interface's
 broadcast address, causing it not to fill the broadcast address array

Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=585591
Reported-by: Paul Martin <pm@debian.org>
Tested-by: Jesper Dangaard Brouer <hawk@comx.dk>
Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>

diff --git a/arping.c b/arping.c
index 9bd6927..2613a12 100644
--- a/arping.c
+++ b/arping.c
@@ -336,7 +336,7 @@ void set_device_broadcast(char *device, unsigned char *ba, size_t balen)
 	for (p = ba, ch = 0; p < ba + balen; p++, ch += 3)
-		*p++ = strtoul(brdcast->value + ch * 3, NULL, 16);
+		*p = strtoul(brdcast->value + ch, NULL, 16);

Attachment: signature.asc
Description: Digital signature

Reply to: