[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#591862: maxima 'serious' bug fix missed freeze



Greetings!

"Adam D. Barratt" <adam@adam-barratt.org.uk> writes:

> On Sat, 2010-09-18 at 10:59 -0400, Camm Maguire wrote:
>> "Adam D. Barratt" <adam@adam-barratt.org.uk> writes:
>> > The upload appears to have introduced several other changes which aren't
>> > documented in the changelog and don't appear related to fixing the bug;
>> > the changelog just says "Backport fixes to 591862 and related items":
> [...]
>> > - A build system change which results in debian/maxout.gnuplot,
>> > debian/tests.lisp.patch, doc/info/extract_categories.sh.debdiff,
>> > doc/info/include-maxima.texi, doc/man/ru/maxima.1 and tests/rtest14.ERR
>> > disappearing from the source package; it's possible some or all of them
>> > were never intended to be shipped, but it's not easy to tell.
> [...]
>> For some as yet still unclear reason, several bug fixes to the maxima
>> package were lost on each upstream upgrade starting from
>> 5.20.1. (e.g. 5.21.0, 5.21.1, 5.22.0, 5.22.1).
> [...]
>> The files listed in your last point are build generated/modified files
>> erroneously included in the source diff.  All of these 'were not
>> intended to be shipped'.  This was a fix erroneously reverted.
>
> I can't find any mention of this in the changelog, although they do
> mostly look like they shouldn't be in the source.
>
> fwiw, the source package currently in unstable includes
> doc/man/ru/maxima.1.
>
>> The replacement of the gv dependency with mime-support and postscript
>> viewer was a fix to an explicit bug which had been erroneously
>> reverted.
>
> This is presumably #590785; this was only applied to the package _after_
> the version currently in testing.
>
>> maxima suggests maxima-emacs was a bug fix erroneously reverted.
>>
>> quilt was an improvement erroneously reverted.
>
> Both of these I can find changelog entries for, although I haven't
> checked the actual packages to verify that the changes were made.
>
> After having argued with myself for a while after this, I've just
> approved the upload.  In future, however, it would be very much
> appreciated if you mention in advance that you were planning on
> including such changes, and include more detailed changelog entries.

Thank you so much, and recommendation duly noted.

Take care,

>
> Regards,
>
> Adam
>
>
>
>
>
>
>

-- 
Camm Maguire			     		    camm@maguirefamily.org
==========================================================================
"The earth is but one country, and mankind its citizens."  --  Baha'u'llah


Reply to: