[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Unblock request for ldns 1.6.6-1, dnsruby 1.49-1 and opendnssec 1.1.2-1



On Sat, Sep 4, 2010 at 15:42, Julien Cristau <jcristau@debian.org> wrote:
> tools/ods-control.in looks like it should exit with an error if it
> doesn't like its command line arguments.

I have prepared patch for this issue and I will upload it as 1.1.2-2
if you say it's ok.

Ondrej
-- 
Ondřej Surý <ondrej@sury.org>
--- a/tools/ods-control.in
+++ b/tools/ods-control.in
@@ -38,16 +38,19 @@ case "$1" in
 'ksm')
 	shift
 	"$bindir/ods-ksmutil" $@
+	exit $?
 	;;
 
 'hsm')
 	shift
 	"$bindir/ods-hsmutil" $@
+	exit $?
 	;;
 	
 'signer')
 	shift
 	"$sbindir/ods-signer" $@
+	exit $?
 	;;
 
 'enforcer')
@@ -98,7 +101,8 @@ case "$1" in
 		;;
 
 	*)
-		echo "usage: $progname enforcer start|stop|notify"
+		echo "usage: $progname enforcer start|stop|notify" >&2
+		exit 3
 		;;
 
 	esac
@@ -116,10 +120,12 @@ case "$1" in
 
 	echo "Stopping signer engine.."
 	"$sbindir/ods-signer" stop
+	exit $?
 	;;
 	
 *)
-	echo "usage: $progname ksm|hsm|signer|enforcer|start|stop ..."
+	echo "usage: $progname ksm|hsm|signer|enforcer|start|stop ..." >&2
+	exit 3
 	;;
 
 esac

Reply to: