Re: Please unblock git-buildpackage 0.5.4
On Wed, Aug 18, 2010 at 02:31:02PM +0100, Julien Cristau wrote:
> On Wed, Aug 18, 2010 at 15:05:45 +0200, Guido Günther wrote:
>
> > On Wed, Aug 18, 2010 at 12:08:53PM +0100, Julien Cristau wrote:
> > > On Tue, Aug 17, 2010 at 08:50:46 +0200, Guido Günther wrote:
> > >
> > > > * [e8b6b49] gbp-pq: Use the maintainer of the Debian package as fallback
> > > > patch author
> > >
> > > Not sure I understand why this is better than using git's default as
> > > author.
> > Note that this is only for patches that don't carry any header
> > information in the patch header - which is often that case if patches
> > aren't generated from git.
> > In this case git-quiltimport would ask for the patch author, that's why
> > we default to the maintainer. In case we can't determine the maintainer
> > (like in the case Mehdi pointed out) we fall back to prompting.
> > Once the patches got imported they cary correct author information and
> > the passed information is ignored by git-quiltimport.
> >
> Fair enough.
>
> > >
> > > > * [af2a435] gbp-pull: Don't update already up to date branches
> > > >
> > > > Since this is a leaf package with no reverse dependencies it should be
> > > > safe.
> > >
> > > Well, if people use it to prepare their package it's better if it keeps
> > > working...
> > >
> > > Quick question:
> > >
> > > --- git-buildpackage-0.5.3/gbp/gbp_version.py 1970-01-01 00:00:00.000000000 +0000
> > > +++ git-buildpackage-0.5.4/gbp/gbp_version.py 2010-08-06 20:14:08.000000000 +0000
> > > @@ -0,0 +1 @@
> > > +gbp_version="0.5.4~1.gbp88afa6"
> > >
> > > what is this for? (is it intended?)
> > The file is autogenerated, so it doesn't matter.
>
> Then presumably it shouldn't be in the source package?
Yes. I'll remove this in further uploads. Thanks for pointing this out.
-- Guido
Reply to: