Re: Please unblock git-buildpackage 0.5.4
On Wed, Aug 18, 2010 at 12:08:53PM +0100, Julien Cristau wrote:
> On Tue, Aug 17, 2010 at 08:50:46 +0200, Guido Günther wrote:
>
> > Hi,
> > please unblock the above version. It fixes a nasty bug regarding dsc
> > imports (which didn't get reported to the bts though):
> >
> > * [f63c4ed] git-import-dsc: Don't add superfluous parents to imports on the
> > Debian branch. Only set a parent on the first import per upstream version.
> >
> > has doc updates:
> >
> > * [407b614] docs: Drop git_load_dirs reference we're not using it anymore.
> > * [dbc7fe3] docs: We don't only support .gz tarballs
> >
> > And minor updates:
> >
> > * [88afa61] git-dch: Pass --multimaint-merge on to dch (Closes: #586165)
> > * [e8b6b49] gbp-pq: Use the maintainer of the Debian package as fallback
> > patch author
>
> Not sure I understand why this is better than using git's default as
> author.
Note that this is only for patches that don't carry any header
information in the patch header - which is often that case if patches
aren't generated from git.
In this case git-quiltimport would ask for the patch author, that's why
we default to the maintainer. In case we can't determine the maintainer
(like in the case Mehdi pointed out) we fall back to prompting.
Once the patches got imported they cary correct author information and
the passed information is ignored by git-quiltimport.
>
> > * [af2a435] gbp-pull: Don't update already up to date branches
> >
> > Since this is a leaf package with no reverse dependencies it should be
> > safe.
>
> Well, if people use it to prepare their package it's better if it keeps
> working...
>
> Quick question:
>
> --- git-buildpackage-0.5.3/gbp/gbp_version.py 1970-01-01 00:00:00.000000000 +0000
> +++ git-buildpackage-0.5.4/gbp/gbp_version.py 2010-08-06 20:14:08.000000000 +0000
> @@ -0,0 +1 @@
> +gbp_version="0.5.4~1.gbp88afa6"
>
> what is this for? (is it intended?)
The file is autogenerated, so it doesn't matter.
-- Guido
Reply to: