[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Pkg-openldap-devel] OpenLDAP upload to unstable.



On Aug 14, 2010, at 5:13 PM, Adam D. Barratt wrote:

> On Tue, 2010-08-10 at 23:44 +0200, Matthijs Möhlmann wrote:
>> On 08/10/2010 10:06 PM, Adam D. Barratt wrote:
>>> Hi,
>>> 
>>> On Mon, 2010-08-09 at 22:48 +0200, Matthijs Möhlmann wrote:
>>>> The changes I made in svn:
>>>> - Move to slapd.conf to slapd.d (upgrade path provided and tested)
>>> 
>>> I must admit that this change makes me a little uneasy at first glance.
>>> I may just be paranoid though. :-)
> [...]
>> As requested the debdiff. I have gzipped it and it still is 39K. That is
>> related to the translation changes.
> 
> Sorry for not getting back to you sooner.  Overall, the diff looks fine;
> thanks.
> 
> A couple of quick comments:
> 
> +       # Check if we need to migrate to the new style.
> +       if previous_version_older 2.4.23-2 || [ -f "${SLAPD_CONF}" ]; then
> 

Correct, fixed in svn.

> Should the version in the above be -3?
> 
> +               # TODO: Now we are doing something that is not allowed by policy but it
> +               # has to be done.
> +               sed -i -e "s|^SLAPD_CONF=.*|SLAPD_CONF=\"${SLAPD_CONF}\"|" /etc/default/slapd
> 
> That comment immediately make me think "uh oh", although I don't
> currently have a better alternative to suggest that wouldn't leave
> people with a broken system after the upgrade.
> 

A broken system is worse then a policy violation in this case. A solution to
this problem is to move the etc/default/slapd file to usr/share/slapd and let
ucf handle this.

Regards,

Matthijs Möhlmann


Reply to: