[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Please unblock tea/28.1.1-1



Am Donnerstag, den 12.08.2010, 22:15 +0100 schrieb Adam D. Barratt:
> On Thu, 2010-08-12 at 22:36 +0200, Tobias Quathamer wrote:
> > the new upstream version fixes only one minor (but annoying) bug, so I
> > thought I'd ask for a freeze exception. I've attached the complete
> > upstream diff between tea 28.1.0 (in testing) and tea 28.1.1 (in
> > unstable).
> 
> From a look at the diff, I'm assuming that the bug is basically "tab
> stops get put in the wrong places"?

Hi,

no, not quite. The tab width is wrongly calculated. The variable
"d->textEdit->spaces_instead_of_tabs" is boolean, so it's either 0 or 1.
The variable "d->textEdit->tab_sp_width" is the amount of spaces for a
tab, usually eight. Therefore, the width of tab stops is wrongly
calculated (always too low).

> (On a side note, the changes to rvln.cpp seem like they probably
> shouldn't be in an upstream release)

That's correct, however, they do not harm ... :-)

Regards,
Tobias

-- 
Tobias Quathamer | The sum of the intelligence of the world is constant.
Hamburg, Germany | The population is, of course, growing.

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil


Reply to: