[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

please unblock flex/2.5.35-6



Hi,

        This release should fix the RC bug that has kept recent versions
 of flex out of lenny. Please do delay for a few days, to see if this
 version allows the packages on IA64 that were broken on the new kernel
 versions there.

        The changelog diff is below.

        manoj

diff --git a/changelog b/changelog
index 5f013cd..a33797a 100644
--- a/changelog
+++ b/changelog
@@ -1,3 +1,102 @@
+flex (2.5.35-6) unstable; urgency=high
+
+  * [f0d7848]: Finish fixing the ia64 buffer issue. Previous commits
+    increased YY_READ_BUF_SIZE (where __ia64__ is defined) but left
+    YY_BUF_SIZE unchanged, so that didn't fix the problem in the end. In
+    the general case, the latter is twice the former. Therefore set it to
+    the same ratio in the ia64 case. Thanks to Cyril Brulebois
+    <kibi@debian.org> for the heavy lifting.
+    Bug fix: "flex scanner push-back overflow", thanks to Sergei Golovan.
+                                                         (Closes: #505056)
+
+ -- Manoj Srivastava <srivasta@debian.org>  Mon, 05 Jan 2009 12:10:01 -0600
+
+flex (2.5.35-5) unstable; urgency=low
+
+  * [debiandir:7eff632]: Fix race conditions in local.mk
+    [62a6595]: Correct a few dependencies in Makefiles
+    These fixes allow flex to be built using make -j3
+    Bug fix: "FTBFS with parallel in DEB_BUILD_OPTIONS", thanks to Daniel
+    Schepler. The heavy lifting was done by Robert Millan (Closes: #507231).
+
+ -- Manoj Srivastava <srivasta@debian.org>  Sat, 29 Nov 2008 20:46:28 -0600
+
+flex (2.5.35-4) unstable; urgency=low
+
+  * [f6cc9ae] Narrow buffer size changes to just IA64
+    Increasing the buffer size on other architectures cause problems in
+    corner cases not caught by the test suite. So perhaps it is not better
+    to increase the buffer size unilatereally for all architectures, but
+    to just increase it for the architecture it is required on, namely,
+    IA64, and leave it unchanged on other architectures. This solution
+    should fix the new grave bugs, while not reopening the original but
+    that cause this change to be done in the first place. 
+    Grave Bug fix: flex scanner push-back overflow, thanks to Sergei
+    Golovan                                       (Closes: #505056, #504030)
+  * [debiandir:9a6d713] Fix VCS-Browser source field.
+    Bug fix: Useless VCS-Browser control field, thanks to Vincent Fourmond
+                                                  (Closes: #503732)
+  * [d58780f] Wrap ECHO macro to avoid FORTIFY warnings
+    This change will enable flex scanners to be compiled with
+    -D_FORTIFY_SOURCE=2, which is a good thing security wise.
+    Bug Fix: flex causing warnings when compiled with FORTIFY_SOURCE,
+    thanks to Kees Cook.                           (Closes: #505233, #388438)
+
+
+ -- Manoj Srivastava <srivasta@debian.org>  Wed, 19 Nov 2008 23:52:09 -0600
+flex (2.5.35-3) unstable; urgency=low
+
+  * Bug fix: "debian dir contains *.so", thanks to Raphael Hertzog
+    This is a simple rname of a file used purely in packaging, and has low
+    risk, but would allow compiling the flex source package with squeeze's
+    packaging tools.                                     (Closes: #485095).
+  * [88bb2fc] Fix generation of broken output on ia64 when input is piped in
+
+    On ia64, flex appears to generate a completely different (and broken)
+    output depending on whether the input file is specified using shell
+    redirection or via a pipe.
+
+    This was traced back commit 3971e1a917548977cff71418a7c3575ffbc9571f,
+    by Alex Nixon <alex.nixon@citrix.com>: VFS: increase pseudo-filesystem
+    block size to PAGE_SIZE. PAGE_SIZE on ia64 kernels is larger than most
+    architectures - 16K is what most distributions (including Debian)
+    use. An effect of the above changeset, as verified by strace, is that
+    the read() and write() system calls issued by flex on a pipe will use
+    this bigger size. fread() appears to be properly hiding the actual
+    read size and is returning 8192 byte buffers to flex upon request. I
+    verified by this by instrumenting YY_INPUT to compare the fread data
+    with the original input file.
+
+    Its probably useful to note that the corruption happening here is that
+    the last 382 lines of the input file is being prefixed to the output
+    file. The only differences in the remainder of the file are the #line
+    numbers. I've also found that bumping YY_READ_BUF_SIZE up to 16384
+    seems to workaround the problem - but that may just be putting it back
+    into hiding.
+
+    The tradeoff here is between correct operation, by making flex's
+    buffer at least as big as the system buffer -- and not bigger, so that
+    we do not waste memory. At this point, fixing the isue seems more
+    important than worrying that flex consumes and additional 8KB of
+    memory.
+
+   This fix unblocks RC bugs on other packages. 
+  
+    Bug fix: "Generates broken output on ia64 when input is piped vs. shell
+    redirection", thanks to Chris Lamb. Fix based on comments by Dann
+    Frazier and Michael Casadevall.                         (Closes: #501960)
+  * [56ec97d] Fix doxygen comments to reflect actual argument name
+    Fix the comments to reflect the actual name of the function
+    arguments. This is a pure documentation fix. 
+    Bug fix: "argument &#39;bytes&#39; of command @param is not found in
+    the argument list of tp_scan_bytes(yyconst char *yybytes, int
+    _yybytes_len)", thanks to Ludovic Rousseau              (Closes: #488272).
+  * [303084a] Merge branch 'topic--buffer-size-patch' [f6cc9ae] Narrow
+    buffer size changes to just IA64
+
+ -- Manoj Srivastava <srivasta@debian.org>  Wed, 19 Nov 2008 22:42:17 -0600

-- 
If a man has a strong faith he can indulge in the luxury of
skepticism. Friedrich Nietzsche
Manoj Srivastava <srivasta@acm.org> <http://www.golden-gryphon.com/>  
1024D/BF24424C print 4966 F272 D093 B493 410B  924B 21BA DABB BF24 424C


Reply to: