[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Freeze exception request: kde4libs 4.1.0-3



Fathi BOUDRA <fabo@debian.org> writes:
> On Tuesday 12 August 2008 23:39:13 Luk Claes wrote:
>> > most important changes on -2 can be found below. They aren't really
>> > massive and not related to symbol files dropped.
>> Why were the symbol files dropped?
> I discussed with Marc (HE) on IRC about the freeze exception request.
> He's on the track too. Maybe sync with him to not duplicate effort.

I'm concerned about the patches to reduce linked in cruft, as they seem
to be a bit ... well, chaotic. I've made the effort to actually compare
the existing patch in Debian, upstream's patch and the one you propose
and noticed a few differences:

khtml: 
Debian: kparts;kjs;kio;kdeui;kdecore
Upstream: kparts;kjs;kio;kdeui;kdecore
Proposed: kparts;kio;kdeui;kdecore

kfile:
Debian: kio;kdeui;kdecore
Proposed: ${QT_QTCORE_LIBRARY};${QT_QTGUI_LIBRARY};kio;kdeui"

kross/ui:
Debian: krosscore
Proposed: ${QT_QTGUI_LIBRARY};kparts

Also, there's a typo in one of the CMakefiles:
++if(WIN32)
++  set(kdecore_LINK_INTERFACE_LIBRARIES "${QT_QTDBUS_LIBRARY};${QT_QTCORE_LIBRARY};${KDEWIN32_LIBRARIES}")
++else(WiN32)

I guess this should be WIN32.

The rest of the diff looks fine, though, so when we have discussed the
linking isses to death, kde4libs should be able to finally go to
testing.

Marc
-- 
BOFH #90:
Budget cuts

Attachment: pgpF5GYtYKdmY.pgp
Description: PGP signature


Reply to: