Re: seeking pre-approval for some perl bugfixes
On Mon, Aug 04, 2008 at 08:02:44PM +0200, Marc 'HE' Brockschmidt wrote:
> Niko Tyni <ntyni@debian.org> writes:
> > #479957: Using IO::File together with POSIX causes warnings. (Constant subroutine main::SEEK_SET redefined)
> > These warnings bother at least eximstat and xscreensaver users.
> > patch attached as 22_fix_constant_subroutine_warnings
>
> I'm too lazy to check the patch context: Will this continue to allow
> importing SEEK_CUR, S_IRGRP and friends from POSIX?
Yes.
> Please use the post-lenny cleanup to sprinkle some newlines around the
> Depends/Conflicts/Replaces fields, policy allows them nowadays and they
> make reading te diff much easier.
Sure, they're a pain for me too as they are.
Many thanks for the reply. Here are a few more, in an order of
increasing difficulty. Could you please ack/nack them too?
#479540: Warning when including perl.h
The fix is trivial.
patch attached as 16_fix_perlio_teardown_prototype
#480719: perl-modules: outdated libfile-temp-perl conflict
Not strictly needed, I suppose, but shouldn't break anything.
patch attached as 480719.patch
#479434: perl: Getopt::Long with subs breaks in Perl 5.10
The fix for this regression is simple and would fix libvcp-perl FTBFS bugs
(#467343 and #479948)
patch attached as 13_fix_getopt_long_callback
#480533: "uninitialized value" warnings from Perl during install
This bloats perl-base, but it's the right thing to do and the d-i people
(at least Otavio) were quite anxious to get the fix in earlier.
I'll have to check with them too, of course.
patch attached as 480533.patch
Thanks again,
--
Niko Tyni ntyni@debian.org
Fix the PerlIO_teardown prototype to suppress a compiler warning. (Closes: #479540)
Part of upstream change 33370, also in maint-5.10.
diff --git a/perl.h b/perl.h
index e48f768..abcae45 100644
--- a/perl.h
+++ b/perl.h
@@ -3966,7 +3966,7 @@ typedef Sighandler_t Sigsave_t;
#endif
#ifdef USE_PERLIO
-EXTERN_C void PerlIO_teardown();
+EXTERN_C void PerlIO_teardown(void);
# ifdef USE_ITHREADS
# define PERLIO_INIT MUTEX_INIT(&PL_perlio_mutex)
# define PERLIO_TERM \
diff --git a/perlio.c b/perlio.c
index 76fe225..b94acb0 100644
--- a/perlio.c
+++ b/perlio.c
@@ -2413,7 +2413,7 @@ PerlIO_cleanup(pTHX)
}
}
-void PerlIO_teardown() /* Call only from PERL_SYS_TERM(). */
+void PerlIO_teardown(void) /* Call only from PERL_SYS_TERM(). */
{
dVAR;
#if 0
diff --git a/perliol.h b/perliol.h
index 756db2d..caba999 100644
--- a/perliol.h
+++ b/perliol.h
@@ -170,7 +170,7 @@ PERL_EXPORT_C void PerlIO_list_free(pTHX_ PerlIO_list_t *list);
/* PerlIO_teardown doesn't need exporting, but the EXTERN_C is needed
* for compiling as C++. Must also match with what perl.h says. */
-EXTERN_C void PerlIO_teardown();
+EXTERN_C void PerlIO_teardown(void);
/*--------------------------------------------------------------------------------------*/
/* Generic, or stub layer functions */
diff --git a/debian/changelog b/debian/changelog
index 2a04f96..0c64c19 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,6 +1,6 @@
perl (5.10.0-11) UNRELEASED; urgency=low
- *
+ * Upgrade libfile-temp-perl conflict to (<= 0.18). (Closes: #480719)
-- Niko Tyni <ntyni@debian.org> Sun, 18 May 2008 22:41:54 +0300
diff --git a/debian/control b/debian/control
index c1633dc..1907033 100644
--- a/debian/control
+++ b/debian/control
@@ -50,7 +50,7 @@ Package: perl-modules
Priority: standard
Architecture: all
Depends: perl (>= ${Upstream-Version}-1)
-Conflicts: libpod-parser-perl (<< 1.32-1), libansicolor-perl (<< 1.10-1), libfile-temp-perl (<< 0.16-1), libnet-perl (<= 1:1.19-3), libattribute-handlers-perl (<< 0.78.02-1), libcgi-pm-perl (<< 3.15-1), libi18n-langtags-perl (<< 0.35-1), liblocale-maketext-perl (<< 1.08-1), libmath-bigint-perl (<< 1.77-1), libnet-ping-perl (<< 2.31-1), libtest-harness-perl (<< 2.56-1), libtest-simple-perl (<< 0.62-1), liblocale-codes-perl (<< 2.06.1-1), libmodule-corelist-perl (<< 2.13-1), libio-zlib-perl (<< 1.07-1), libarchive-tar-perl (<= 1.38-2), libextutils-cbuilder-perl (<< 0.21-1), libmodule-build-perl (<< 0.2808.1-1), libmodule-load-perl (<< 0.12-1), liblocale-maketext-simple-perl (<< 0.18-1), libparams-check-perl (<< 0.26-1), libmodule-pluggable-perl (<< 3.6-1), libmodule-load-conditional-perl (<< 0.22-1), libcpan-plus-perl (<< 0.83.09-1), libversion-perl (<< 1:0.7400-2)
+Conflicts: libpod-parser-perl (<< 1.32-1), libansicolor-perl (<< 1.10-1), libfile-temp-perl (<< 0.18), libnet-perl (<= 1:1.19-3), libattribute-handlers-perl (<< 0.78.02-1), libcgi-pm-perl (<< 3.15-1), libi18n-langtags-perl (<< 0.35-1), liblocale-maketext-perl (<< 1.08-1), libmath-bigint-perl (<< 1.77-1), libnet-ping-perl (<< 2.31-1), libtest-harness-perl (<< 2.56-1), libtest-simple-perl (<< 0.62-1), liblocale-codes-perl (<< 2.06.1-1), libmodule-corelist-perl (<< 2.13-1), libio-zlib-perl (<< 1.07-1), libarchive-tar-perl (<= 1.38-2), libextutils-cbuilder-perl (<< 0.21-1), libmodule-build-perl (<< 0.2808.1-1), libmodule-load-perl (<< 0.12-1), liblocale-maketext-simple-perl (<< 0.18-1), libparams-check-perl (<< 0.26-1), libmodule-pluggable-perl (<< 3.6-1), libmodule-load-conditional-perl (<< 0.22-1), libcpan-plus-perl (<< 0.83.09-1), libversion-perl (<< 1:0.7400-2)
Replaces: libpod-parser-perl, libansicolor-perl, libfile-temp-perl, libnet-perl, libattribute-handlers-perl, libcgi-pm-perl, libi18n-langtags-perl, liblocale-maketext-perl, libmath-bigint-perl, libnet-ping-perl, libtest-harness-perl, libtest-simple-perl, liblocale-codes-perl, libmodule-corelist-perl, libio-zlib-perl, libarchive-tar-perl, libextutils-cbuilder-perl, libmodule-build-perl, libmodule-load-perl, liblocale-maketext-simple-perl, libparams-check-perl, libmodule-pluggable-perl, libmodule-load-conditional-perl, libcpan-plus-perl, libversion-perl
Provides: libpod-parser-perl, libansicolor-perl, libfile-temp-perl, libnet-perl, libattribute-handlers-perl, libcgi-pm-perl, libi18n-langtags-perl, liblocale-maketext-perl, libmath-bigint-perl, libnet-ping-perl, libtest-harness-perl, libtest-simple-perl, liblocale-codes-perl, libmodule-corelist-perl, libio-zlib-perl, libarchive-tar-perl, libextutils-cbuilder-perl, libmodule-build-perl, libmodule-load-perl, liblocale-maketext-simple-perl, libparams-check-perl, libmodule-pluggable-perl, libmodule-load-conditional-perl, libcpan-plus-perl, libversion-perl
Description: Core Perl modules
Remove numeric overloading of Getopt::Long callback functions. (Closes: #479434)
The numeric overloading introduced in Getopt::Long 2.36 broke
lintian and libvcp-perl.
Dual-lived module, fixed on the CPAN side in 2.37_01.
[rt.cpan.org #35759]
diff --git a/lib/Getopt/Long.pm b/lib/Getopt/Long.pm
index f44e615..b5f94b1 100644
--- a/lib/Getopt/Long.pm
+++ b/lib/Getopt/Long.pm
@@ -1483,7 +1483,6 @@ sub name {
use overload
# Treat this object as an oridinary string for legacy API.
'""' => \&name,
- '0+' => sub { 0 },
fallback => 1;
1;
diff --git a/debian/control b/debian/control
index f27146e..8582eb7 100644
--- a/debian/control
+++ b/debian/control
@@ -13,7 +13,7 @@ Priority: required
Architecture: any
Pre-Depends: ${shlibs:Depends}
Conflicts: autoconf2.13 (<< 2.13-45), libscalar-list-utils-perl (<< 1:1.18-1), libxsloader-perl (<< 0.08-1)
-Replaces: perl (<= 5.10.0-9), perl-modules (<< 5.8.8-8), libperl5.8 (<< 5.8.0-20), libscalar-list-utils-perl, libclass-multimethods-perl (<< 1.70-4), libxsloader-perl
+Replaces: perl (<= 5.10.0-9), perl-modules (<= 5.10.0-11.1), libperl5.8 (<< 5.8.0-20), libscalar-list-utils-perl, libclass-multimethods-perl (<< 1.70-4), libxsloader-perl
Provides: perl5-base, ${perlapi:Provides}, libscalar-list-utils-perl, libxsloader-perl
Suggests: perl
Description: minimal Perl system
diff --git a/debian/perl-base.files b/debian/perl-base.files
index c1abee5..2ae1d2a 100644
--- a/debian/perl-base.files
+++ b/debian/perl-base.files
@@ -67,6 +67,7 @@ usr/share/perl/*/utf8_heavy.pl
usr/share/perl/*/unicore/PVA.pl
usr/share/perl/*/unicore/Exact.pl
usr/share/perl/*/unicore/Canonical.pl
+usr/share/perl/*/unicore/lib
usr/share/perl/*/vars.pm
usr/share/perl/*/warnings.pm
usr/share/perl/*/warnings/register.pm
Reply to: