Re: Please unblock qmail-src 1.03-42
Jon,
On Sat, Jan 13, 2007 at 12:16:55AM -0600, Jon Marler wrote:
> Quoting Steve Langasek <vorlon@debian.org>:
> > On Mon, Jan 08, 2007 at 08:09:48AM -0600, Jon Marler wrote:
> > > I have fixed the RC build bug (#402331) in qmail-src 1.03-42.
> > There are some changes in debian/rules to comment out properly setting the
> > owner of various files in the install tree:
> > - chown -R root.root debian/tmp/usr/man
> > + #chown -R root.root debian/tmp/usr/man
> > [...]
> > - chown -R root.root $(TMPSRC)
> > + #chown -R root.root $(TMPSRC)
> > Could you explain why this is? That looks like a regression to me.
> I couldn't get the package to build without commenting out those lines. I
> commented them out fearing that you would call it another RC bug since it still
> wouldn't build, although the package has been this way since it's inception 10
> years ago.
Debian package builds are supposed to be done as root (real root or
fakeroot), and the contents of the resulting packages are supposed to be
owned by root unless there's a specific reason. Sounds like you weren't
testing as root?
> Are you telling me now that the package needs yet another patch? If so,
> please let me know ASAP, and I'll get a new version uploaded.
Well, this was a violation of policy 10.9, so I'm glad to see that it's
fixed. But:
On Mon, Jan 15, 2007 at 01:16:14PM -0600, Jon Marler wrote:
> This is fixed in -43 which has just been uploaded.
> -43 also updates the standards version, and removes some old 1.02 upgrade
> code and fixes a usr/doc link issue thanks to a great patch that was
> included with the bug.
It also introduces another policy violation. Build-Depends is a source
package field, and you've removed it from the source package stanza and
moved it to the binary package stanza.
@@ -2,13 +2,12 @@
Maintainer: Jon Marler <jmarler@debian.org>
Section: non-free/mail
Priority: extra
-Build-Depends: dpkg-dev (>= 1.4.0.20), patch (>= 2.5-0bo1), gcc, make, fakeroot | sudo, groff-base, debconf | debconf-2.0
-Standards-Version: 3.5.0.0
+Standards-Version: 3.7.2
Package: qmail-src
Architecture: all
-Depends: dpkg-dev (>= 1.4.0.20), patch (>= 2.5-0bo1), gcc, make, fakeroot | sudo, groff-base, debconf | debconf-2.0
-Build-Depends: dpkg-dev (>= 1.4.0.20), patch (>= 2.5-0bo1), gcc, make, fakeroot | sudo, groff-base, debconf | debconf-2.0
+Depends: dpkg-dev (>= 1.4.0.20), patch (>= 2.5-0bo1), gcc, make, fakeroot | sudo, groff-base, adduser
+Build-Depends: dpkg-dev (>= 1.4.0.20), patch (>= 2.5-0bo1), gcc, make, fakeroot | sudo, groff-base, adduser
Conflicts: qmail-run, qmail-uids-gids
Section: non-free/mail
Recommends: ucspi-tcp-src, procmail
That again fails the autobuildability requirement, and needs to be fixed.
If you can fix this one issue, it shouldn't be a problem to get qmail back
into etch.
Thanks,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
vorlon@debian.org http://www.debian.org/
Reply to: