[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#404876: NMU for libvisual breaking gnome on non-altivec powerpc machines.



On Mon, Mar 05, 2007 at 05:57:13PM -0800, Steve Langasek wrote:
> Hi Sjoerd,
> On Mon, Mar 05, 2007 at 12:02:47PM +0100, Sjoerd Simons wrote:
> 
> > I've just uploaded an NMU of libvisual to the DELAYED/2-day queue on gluck,
> > which works around the issue of the altivec detection causing gstreamer to 
> > segv on some powerpc machines without altivec. Which in turn breaks the gnome 
> > desktop on these machines. The workaround simply completely disables the 
> > altivec detection.
> 
> Where is the diff for this NMU, please?

Oh, forgot to attach it, sorry. See attachment

> > With this workaround #404876 and #407153 can either be closed or downgraded
> > && retitled to please enable/fix altivec detection.
> 
> Have you not closed these bugs in the changelog of your NMU?

No, as Loic mentioned in his mail we decided that this bug should be downgraded
instead of being closed as it's just a work-around instead of a real fix.

If you prefer, i can ofcourse upload a new version which does clone the bug and
we can do some magic to open a new one with the same info, stating what
actually should be fixed :)

  Sjoerd
PS: Please keep me CC'd in replies
-- 
Expansion means complexity; and complexity decay.
diff -u libvisual-0.4.0/debian/changelog libvisual-0.4.0/debian/changelog
--- libvisual-0.4.0/debian/changelog
+++ libvisual-0.4.0/debian/changelog
@@ -1,3 +1,11 @@
+libvisual (0.4.0-1.1) unstable; urgency=high
+
+  * NMU
+  * Disable altivec detection code, it breaks gstreamer on machines without
+    altivec.
+
+ -- Sjoerd Simons <sjoerd@debian.org>  Sun, 14 Jan 2007 14:26:45 +0100
+
 libvisual (0.4.0-1) unstable; urgency=low
 
   * New upstream release
only in patch2:
unchanged:
--- libvisual-0.4.0.orig/libvisual/lv_cpu.c
+++ libvisual-0.4.0/libvisual/lv_cpu.c
@@ -143,6 +143,7 @@
 
 static void check_os_altivec_support( void )
 {
+  return;
 #if defined(VISUAL_OS_DARWIN)
 	int sels[2] = {CTL_HW, HW_VECTORUNIT};
 	int has_vu = 0;

Reply to: