Re: RC bug fixed in qps
Marc has already noted why this fix is insufficient. Some further comments
below.
On Sun, Feb 25, 2007 at 03:30:04AM +0100, René Mérou wrote:
> Here is the interdiff:
> -----------------------------------------------------------------------------------------------
> interdiff qps_1.9.18.6-1.diff qps_1.9.18.6-2.diff
> diff -u qps-1.9.18.6/debian/changelog qps-1.9.18.6/debian/changelog
> --- qps-1.9.18.6/debian/changelog
> +++ qps-1.9.18.6/debian/changelog
> @@ -1,3 +1,9 @@
> +qps (1.9.18.6-2) unstable; urgency=low
> +
> + * Does not fails to build. Closes: #411845
> +
> + -- René <h@privacy.ono.com> Sat, 24 Feb 2007 17:37:04 +0100
> +
This is not a proper changelog entry. A changelog is for recording what you
*changed*; all you've given here is a text description of the bug.
> this are the changes made in rules:
> before:
> clean:
> dh_testdir
> dh_testroot
> rm -f build-stamp
> rm -f proc.cpp
> [ ! -f Makefile ] || { $(MAKE) distclean && rm -f Makefile; }
> after:
> clean:
> dh_testdir
> dh_testroot
> rm -f build-stamp
> #rm -f proc.cpp
Please don't leave useless comments behind when changing code; this
needlessly clutters the code later, and in fact makes reviewing the diff
more time-consuming.
> [ ! -f Makefile ] || { $(MAKE) distclean && rm -f Makefile; }
> dh_clean proc.cpp
FWIW, an ideal fix is for the upstream distclean rule to clean up this file
it's created, so I highly recommend that as the long-term fix. For the
immediate fix, that's not a requirement.
But the build failures on alpha, mips, and mipsel also show an error in the
upstream distclean target; they're creating, and leaving behind, .obj
directories owned by the user running the clean target (with -rsudo, this is
root), instead of leaving a genuinely clean build directory.
Cheers,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
vorlon@debian.org http://www.debian.org/
Reply to: