Re: Please unblock probcons 1.11-1
Le Fri, Feb 23, 2007 at 05:36:58PM -0800, Steve Langasek a écrit :
> On Thu, Feb 22, 2007 at 10:40:10AM +0900, Charles Plessy wrote:
> > the new upstream version of probcons is a bugfix.
>
> And how does it fix this bug? There's no information what these '--annot'
> and '-a' options are supposed to do, and the changes are pretty clearly not
> fixes to getopt handling...
Good question... I am not a programmer, but both options are affecting
the output of probcons, and it seems to me that the changes are
dealing with this. From the manpage:
-annot FILENAME
write annotation for multiple alignment to FILENAME
-a --alignment-order
print sequences in alignment order rather than input order
(default: off)
Most changed lines of Main.cc have keywords such as "sort" or "order",
so I guess that probcons 1.10 was not ordering correctly the annotations
when the alignment order was chanded with the -a option.
This said, I am not a programmer, and although I have tested the
capacity of probcons to produce a good biological sequence alignment, I
have not tested those options because I do not what to expect from
-annot.
Have a nice day, and thank you for the time you spent on probcons.
--
Charles Plessy
http://charles.plessy.org
Wako, Saitama, Japan
Reply to: