"schönfeld / in-medias-res.com" <schoenfeld@in-medias-res.com> writes: >> Mark Purcell wrote: >>> smstools (3.0.2-3) unstable; urgency=medium >>> * Urgency medium as this clears a bug in the upgrade path: >>> Added prerm script to handle upgrade from 3.0-1 to this version >>> (Closes: #403615) >> >> --- smstools-3.0.2.orig/debian/prerm >> +++ smstools-3.0.2/debian/prerm >> @@ -0,0 +1,6 @@ >> +#!/bin/sh >> +set -e >> + >> +if ! "$1" = 'failed-upgrade'; then >> + #DEBHELPER# >> +fi >> >> This looks not right as it will try to execute $1, which will probably already >> fail with an error message AFAICS... > Ehhm. Why should that try to _execute_ $1 ? It does what it is supposed > to do. No, it doesn't: he@pindar:~$ bar="failed-upgrade"; if ! "$bar" = 'failed-upgrade'; then echo lala; fi bash: failed-upgrade: command not found > It checks weither the parameter to debian/prerm is failed-upgrade or > not. if [ ! "$1" = 'failed-upgrade' ]; is what you want. Marc -- BOFH #420: Feature was not beta tested
Attachment:
pgpCZHVxaWP6B.pgp
Description: PGP signature