Re: unfreeze request - smstools (3.0.2-3)
On Thu, Feb 8, 2007 at 11:49:39 +0100, "schönfeld / in-medias-res.com" wrote:
> > --- smstools-3.0.2.orig/debian/prerm
> > +++ smstools-3.0.2/debian/prerm
> > @@ -0,0 +1,6 @@
> > +#!/bin/sh
> > +set -e
> > +
> > +if ! "$1" = 'failed-upgrade'; then
> > + #DEBHELPER#
> > +fi
> >
> > This looks not right as it will try to execute $1, which will probably already
> > fail with an error message AFAICS...
>
> Ehhm. Why should that try to _execute_ $1 ?
>
Because that's what it does. I believe you meant to *test* if "$1" is
'failed-upgrade', but to actually do that you need to run the test
command, which you don't.
so the correct thing to do is probably:
if ! [ "$1" = failed-upgrade ]; then
...
Cheers,
Julien
Reply to: