[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Please unblock nfs-utils/1:1.0.10-6



As per IRC request, please
  
  unblock nfs-utils/1:1.0.10-6

The current version in testing is 1:1.0.10-4. 1:1.0.10-5 fixed a normal bug,
and has been in unstable since December 21st with no new bugs reported over
1:1.0.10-4, 1:1.0.10-6 fixes an important bug where nfs-utils would be built
with no tcpwrappers support. This is a regression from sarge, and seems to be
caused by upstream changing autofoo in 1.0.8 (which entered Debian in June --
unfortunately nobody noticed until now).

The fix for 1:1.0.10-6 is a single line on top of 1:1.0.10-5 (the
build-dependency was already in place, since we never actively removed the
support); the entire debdiff from 1:1.0.10-4 is:

diff -u nfs-utils-1.0.10/debian/changelog nfs-utils-1.0.10/debian/changelog
--- nfs-utils-1.0.10/debian/changelog
+++ nfs-utils-1.0.10/debian/changelog
@@ -1,3 +1,24 @@
+nfs-utils (1:1.0.10-6) unstable; urgency=medium
+
+  * Give --with-tcp-wrappers to configure; for some reason it stopped being
+    enabled by default in 1.0.8. (Closes: #408365)
+
+ -- Steinar H. Gunderson <sesse@debian.org>  Thu, 25 Jan 2007 12:45:38 +0100
+
+nfs-utils (1:1.0.10-5) unstable; urgency=medium
+
+  * The NFS kernel server does not support uid mappings, activated with flags
+    such as "map_daemon" in exports. There is already code that parses these
+    flags, and gives an error at mount time if an unsupported flag (ie. any
+    but the default) is given. However, at some point the kernel changed the
+    export interface, and the new code forgot to include the relevant check.
+    Thus, simply copy the check from the old to the new code, which makes
+    sure mountd behaves the same in this aspect regardless of kernel version,
+    and makes sure the admin does not inadvertedly use map_daemon and expect
+    it to work. (Closes: #403232)
+
+ -- Steinar H. Gunderson <sesse@debian.org>  Thu, 21 Dec 2006 12:13:10 +0100
+
 nfs-utils (1:1.0.10-4) unstable; urgency=low
 
   * README.Debian.nfsv4 updates.
diff -u nfs-utils-1.0.10/debian/rules nfs-utils-1.0.10/debian/rules
--- nfs-utils-1.0.10/debian/rules
+++ nfs-utils-1.0.10/debian/rules
@@ -17,7 +17,8 @@
 endif
 	CFLAGS="-g -O2 -Wall" ./configure \
 		--mandir='$${prefix}/share/man' \
-		--enable-secure-statd 
+		--enable-secure-statd \
+		--with-tcp-wrappers
 	$(MAKE)
 	touch build-stamp
 
only in patch2:
unchanged:
--- nfs-utils-1.0.10.orig/utils/mountd/cache.c
+++ nfs-utils-1.0.10/utils/mountd/cache.c
@@ -381,6 +381,12 @@
 {
 	FILE *f;
 
+	if (exp->m_export.e_maptype != CLE_MAP_IDENT) {
+		xlog(L_ERROR, "%s: unsupported mapping; kernel supports only 'identity' (default)",
+		    exp->m_export.m_path);
+		return;
+	}
+
 	f = fopen("/proc/net/rpc/auth.unix.ip/channel", "w");
 	if (!f)
 		return;

If needed, I'll be happy to make an upload to t-p-u with only the change for
tcpwrapper support. Thanks for considering. :-)

/* Steinar */
-- 
Homepage: http://www.sesse.net/



Reply to: