Hi Brendan On request of Marc, I started reviewing perl for testing migration, but I found a strange thing. Brendan, can you please comment: Why is $stuff used before it's declared in the below part of diff? --- perl-5.8.8.orig/lib/perl5db.pl +++ perl-5.8.8/lib/perl5db.pl @@ -6354,9 +6354,13 @@ $OUT->write( join( '', @_ ) ); # Receive anything there is to receive. - my $stuff; - $IN->recv( $stuff, 2048 ); # XXX "what's wrong with sysread?" - # XXX Don't know. You tell me. + $stuff; + my $stuff = ''; + my $buf; + do { + $IN->recv( $buf = '', 2048 ); # XXX "what's wrong with sysread?" + # XXX Don't know. You tell me. + } while length $buf and ($stuff .= $buf) !~ /\n/; # What we got. $stuff; Cheers Luk -- Luk Claes - http://people.debian.org/~luk - GPG key 1024D/9B7C328D Fingerprint: D5AF 25FB 316B 53BB 08E7 F999 E544 DE07 9B7C 328D
Attachment:
signature.asc
Description: OpenPGP digital signature