[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: How are things going?



Hi,

On Fri, 2006-09-29 at 22:35:33 -0700, Steve Langasek wrote:
> Carry on :-)

Ok, there has been one last commit to svn, and I'd like approval
before the planned upload for today. Attached the diff. And here's
both changelogs entries.

debian/changelog:
  * Require POSIX inside subprocerr in controllib.pl. Closes: #390636

ChangeLog:
2006-10-03  Brendan O'Dea  <bod@debian.org>

	* scripts/controllib.pl (subprocerr): Require POSIX for WIFEXITED,
	WEXITSTATUS, WIFSIGNALED and WTERMSIG.

regards,
guillem
Index: scripts/controllib.pl
===================================================================
--- scripts/controllib.pl	(revision 540)
+++ scripts/controllib.pl	(revision 541)
@@ -430,12 +430,13 @@
 
 sub subprocerr {
     local ($p) = @_;
-    if (WIFEXITED($?)) {
+    require POSIX;
+    if (POSIX::WIFEXITED($?)) {
         die sprintf(_g("%s: failure: %s gave error exit status %s"),
-                    $progname, $p, WEXITSTATUS($?))."\n";
-    } elsif (WIFSIGNALED($?)) {
+                    $progname, $p, POSIX::WEXITSTATUS($?))."\n";
+    } elsif (POSIX::WIFSIGNALED($?)) {
         die sprintf(_g("%s: failure: %s died from signal %s"),
-                    $progname, $p, WTERMSIG($?))."\n";
+                    $progname, $p, POSIX::WTERMSIG($?))."\n";
     } else {
         die sprintf(_g("%s: failure: %s failed with unknown exit code %d"),
                     $progname, $p, $?)."\n";

Reply to: