[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: lilo ignores failures on upgrade, leaving the system silently unbootable



tags 304260 - patch
thanks
On Sun, May 15, 2005 at 06:20:45AM -0700, Steve Langasek wrote:
> 
> Hi Andrés,
> 
> I've prepared a 0-day NMU for this bug, which will be uploaded shortly.  The
> patch is attached.
>  
>    * debian/patches/15_space-bug.dpatch:
> diff -u lilo-22.6.1/debian/lilo.postinst lilo-22.6.1/debian/lilo.postinst
> --- lilo-22.6.1/debian/lilo.postinst
> +++ lilo-22.6.1/debian/lilo.postinst
> @@ -68,7 +68,7 @@
>  	db_get lilo/runme || true;
>  	if [ "$RET" = "true" ]; then
>  		echo "Running lilo..."
> -		/sbin/lilo || true
> +		/sbin/lilo
>  	fi
>  
>  	;;

Hello Steve,
This patch is a noop, because lilo.postinst does not 'set -x', (which is
yet another policy violation), so the error status of lilo is ignored
anyway. This caused problems in upgrade-report bug #310653.

Cheers,
-- 
Bill. <ballombe@debian.org>

Imagine a large red swirl here. 



Reply to: