[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#309591: pmount: DANGEROUS default settings (sync)



Hi Sjoerd,

On Thu, May 19, 2005 at 12:20:13AM +0200, Sjoerd Simons wrote:
> On Wed, May 18, 2005 at 05:32:34PM +0200, Martin Pitt wrote:

> > Steve Langasek [2005-05-18  4:38 -0700]:
> > > > I read the thread and it convinced me to change the pmount default
> > > > from sync to async (which would be a trivial change) and replace the
> > > > --async option with a --sync option. The advantages (don't destroy
> > > > flash hardware and greatly speed up the writing process) outweigh the
> > > > disadvantages (protect users from corruption if they don't unmount
> > > > their drives) IMHO.

> > > > I will prepare the patch ASAP and send it to this bug. In the
> > > > meantime, would you accept this change for Sarge?

> > > If you think that's the correct course of action for addressing this bug,
> > > then yes.

> > Alright, I uploaded 

> >  pmount (0.8-2) unstable; urgency=high
> >  .
> >    * Urgency high since this fixes an RC bug, the fix should reach Sarge.
> >    * Added debian/patches/02-async_by_default.patch:
> >      - Mount devices 'async' by default instead of 'sync'. This will avoid
> >        physical damage of flash chips due to exaggerated updating of inode/FAT
> >        structures and greatly speed up the write throughput. On the bad side
> >        this makes it much less safe to remove devices without proper umounting.
> >      - Replace option "--async" with option "--sync".
> >      - Document change in the manpages.
> >      - Closes: #309591
> >    * debian/control: Correct package priority to optional, to match the katie
> >      overrides.

> > The applied patch can be seen at [1], it's pretty trivial.

> > I also talked with Sjoerd Simons (hal maintainer). Above pmount upload
> > will fix the issue for command line users of pmount, but for Utopia users
> > (i. e. who use gnome-volume-manager and hal) the policy needs to be
> > fixed in hal; this means nothing more than removing the sync/async
> > policy stanza from the policy XML file, so I kindly ask to approve
> > this as well (Sjoerd will prepare an update soon).

> Just uploaded hal 0.4.7-3sarge1 to testing-proposed-updates. This removes the
> sync option from the default setup and adds a warning to the example fdi config
> file. 

> Please approve for Sarge.

If I'm reading right, this change also disables the noatime setting that was
previously enabled for small drives.  Wouldn't we want that to stay enabled?

Thanks,
-- 
Steve Langasek
postmodern programmer

Attachment: signature.asc
Description: Digital signature


Reply to: