[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#309591: pmount: DANGEROUS default settings (sync)



On Wed, May 18, 2005 at 01:25:55PM +0200, Martin Pitt wrote:
> Steve Langasek [2005-05-18  1:05 -0700]:
> > > apparently the sync option really should *NOT* be used, especially not by
> > > default:
> > 
> > > http://readlist.com/lists/vger.kernel.org/linux-kernel/22/111748.html
> > 
> > This may or may not be a grave bug, but AFAIK it doesn't apply to sarge
> > because the kernels in sarge do not support sync on FAT/VFAT.

> That's not entirely true. Older kernels indeed do not completely
> implement sync on vfat, but at least to a certain degree; there is
> still a small amount of data that does get written after calling
> "sync", but it is by no way the same amount of data that gets written
> when mounting async.

> I read the thread and it convinced me to change the pmount default
> from sync to async (which would be a trivial change) and replace the
> --async option with a --sync option. The advantages (don't destroy
> flash hardware and greatly speed up the writing process) outweigh the
> disadvantages (protect users from corruption if they don't unmount
> their drives) IMHO.

> I will prepare the patch ASAP and send it to this bug. In the
> meantime, would you accept this change for Sarge?

If you think that's the correct course of action for addressing this bug,
then yes.

Thanks,
-- 
Steve Langasek
postmodern programmer

Attachment: signature.asc
Description: Digital signature


Reply to: