[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#309591: pmount: DANGEROUS default settings (sync)



Hi Martin,

On Wed, May 18, 2005 at 05:32:34PM +0200, Martin Pitt wrote:
> Steve Langasek [2005-05-18  4:38 -0700]:
> > > I read the thread and it convinced me to change the pmount default
> > > from sync to async (which would be a trivial change) and replace the
> > > --async option with a --sync option. The advantages (don't destroy
> > > flash hardware and greatly speed up the writing process) outweigh the
> > > disadvantages (protect users from corruption if they don't unmount
> > > their drives) IMHO.
> > 
> > > I will prepare the patch ASAP and send it to this bug. In the
> > > meantime, would you accept this change for Sarge?
> > 
> > If you think that's the correct course of action for addressing this bug,
> > then yes.

> Alright, I uploaded 

>  pmount (0.8-2) unstable; urgency=high
>  .
>    * Urgency high since this fixes an RC bug, the fix should reach Sarge.
>    * Added debian/patches/02-async_by_default.patch:
>      - Mount devices 'async' by default instead of 'sync'. This will avoid
>        physical damage of flash chips due to exaggerated updating of inode/FAT
>        structures and greatly speed up the write throughput. On the bad side
>        this makes it much less safe to remove devices without proper umounting.
>      - Replace option "--async" with option "--sync".
>      - Document change in the manpages.
>      - Closes: #309591
>    * debian/control: Correct package priority to optional, to match the katie
>      overrides.

> The applied patch can be seen at [1], it's pretty trivial.

Ok, approved.

Is there any value in continuing to provide the --async commandline option
for purposes of backwards compatibility?

Thanks,
-- 
Steve Langasek
postmodern programmer

Attachment: signature.asc
Description: Digital signature


Reply to: