[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Pushing gtk+2.0 (2.6.4-2)



Oi kov,

On Tue, May 10, 2005 at 01:04:39AM -0300, Gustavo Noronha Silva wrote:
> As with gconf2 I just uploaded gtk+2.0 2.6.4-2 fixing a documentation
> problem related to its devhelp file and including a patch grabbed from
> upstream's CVS to fix a sucky focus problem, following the main
> maintainer's advice.

> This later problem can be quite a big inconvenience for users of
> combinations like ion and firefox or other gtk2-based apps; the fix was
> written and incorporated by upstream on HEAD and on the stable branch,
> so we consider it to be safe.

The diff also seems to contain changes not documented in the changelog,
which look quite intrusive:

--- gtk+2.0-2.6.4/debian/patches/004_fs_newdir.patch
+++ gtk+2.0-2.6.4.orig/debian/patches/004_fs_newdir.patch
@@ -1,40 +0,0 @@

<file completely removed>

--- gtk+2.0-2.6.4/debian/rules
+++ gtk+2.0-2.6.4/debian/rules
@@ -121,7 +121,7 @@
 
        touch $@
 
-configure: configure-static configure-shared
+configure: configure-shared
 
 build-shared: debian/control configure-shared
$(STAMP_DIR)/build-shared-stamp
 $(STAMP_DIR)/build-shared-stamp:
@@ -147,7 +147,7 @@
 
        touch $@
 
-build: build-static build-shared
+build: build-shared
 
 clean:: debian/control
        dh_testdir
@@ -182,7 +182,7 @@
                RUN_QUERY_IMMODULES_TEST=false \
                RUN_QUERY_LOADER_TEST=false
 
-install: install-static install-shared
+install: install-shared
        # generating debian files from .in
        for f in `find debian/ -name "[^c]*.in"; do \
                sed -e "s/@VERSION@/${version}/g" -e "s/@MODVER@/${modver}/g" -e  "s/@APIVER@/${apiver}/g" $$f > `echo $$f | sed -e "s/\.in//"; \
--- gtk+2.0-2.6.4/debian/shlibs.local
+++ gtk+2.0-2.6.4.orig/debian/shlibs.local
@@ -1,4 +0,0 @@
-libgdk_pixbuf-2.0 0 libgtk2.0-0 (>= 2.6.0)
-libgdk-x11-2.0 0 libgtk2.0-0 (>= 2.6.0)
-libgtk-x11-2.0 0 libgtk2.0-0 (>= 2.6.0)
-libgdk_pixbuf_xlib-2.0 0 libgtk2.0-0 (>= 2.6.0)


Please explain what's going on with these changes, or (perhaps easier
anyway) upload a package that reverts them so that the other changes can be
approved more quickly.

BTW, I think the following change is also a no-op, because there is no
libgtk2.0-dbg package in sarge/sid:

only in patch2:
--- gtk+2.0-2.6.4.orig/debian/libgtk2.0-dbg.files
+++ gtk+2.0-2.6.4/debian/libgtk2.0-dbg.files
@@ -0,0 +1 @@
+usr/lib/debug/*
only in patch2:
--- gtk+2.0-2.6.4.orig/debian/libgtk2.0-dbg.dirs
+++ gtk+2.0-2.6.4/debian/libgtk2.0-dbg.dirs
@@ -0,0 +1 @@
+usr/lib/debug

Thanks,
-- 
Steve Langasek
postmodern programmer

Attachment: signature.asc
Description: Digital signature


Reply to: