[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Please push adduser 3.62 into testing



On Thu, Mar 03, 2005 at 10:06:08PM -0800, Steve Langasek wrote:
> @@ -718,23 +726,24 @@
>  # is name ok?
>  sub checkname {
>      my ($name) = @_;
> -    if ($allow_badname && $name !~ /^[A-Za-z_][-_A-Za-z0-9]*\$?$/) {
> +    if ($name !~ /^[-\.A-Za-z0-9]*\$?$/) {
>         print STDERR
> -"$0: ",_("To avoid problems, the username should consist of a letter or
> -underscore followed by letters, digits, underscores, and dashes. For
> -compatibility with Samba machine accounts \$ is also supported at the
> -end of the username\n");
> +"$0: ",_("To avoid problems, the username should consist of
> +letters, digits, underscores, periods and dashes. For compatibility with
> +Samba machine accounts \$ is also supported at the end of the username\n");
>         exit 1;
>      }
> 
> At a glance, this change to adduser seems to be intended to relax the regex
> used for checking the validity of the usernames, but on close inspection I
> see that _ was previously an allowed character and is no longer allowed
> (even if configuring name_regex).  I don't see any rationale for this change
> in the changelog, could you explain why this was done?

This is obviously a mistake. I'll upload a new version.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835



Reply to: