Hi Marc,
On Mon, Feb 28, 2005 at 07:36:25AM +0100, Marc Haber wrote:
> please consider pushing adduser 3.62 into testing. The package hass
> been in sid for 10 days without bad bugs surfacing, and has spent some
> time in experimental before. It fixes a number of small bugs, and has
> a number of new safety features which can be used to avoid bigger
> parts of the system (including / and /usr) when removing accounts with
> insanely set home directories.
> If you need any more information, please ask.
@@ -718,23 +726,24 @@
# is name ok?
sub checkname {
my ($name) = @_;
- if ($allow_badname && $name !~ /^[A-Za-z_][-_A-Za-z0-9]*\$?$/) {
+ if ($name !~ /^[-\.A-Za-z0-9]*\$?$/) {
print STDERR
-"$0: ",_("To avoid problems, the username should consist of a letter or
-underscore followed by letters, digits, underscores, and dashes. For
-compatibility with Samba machine accounts \$ is also supported at the
-end of the username\n");
+"$0: ",_("To avoid problems, the username should consist of
+letters, digits, underscores, periods and dashes. For compatibility with
+Samba machine accounts \$ is also supported at the end of the username\n");
exit 1;
}
At a glance, this change to adduser seems to be intended to relax the regex
used for checking the validity of the usernames, but on close inspection I
see that _ was previously an allowed character and is no longer allowed
(even if configuring name_regex). I don't see any rationale for this change
in the changelog, could you explain why this was done?
Thanks,
--
Steve Langasek
postmodern programmer
Attachment:
signature.asc
Description: Digital signature