[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Asking permission to upload of KSensors in testing-proposed-updates



Hi all,

I recently upload (but before the last call for low urgency uploads) a
new revision of KSensors that fixes two bugs:
- A crash when configuring the panels (bug #225712, #265806)
- Problem in displaying the values (bug#265807).

The last bug was triggered by Qt 3.3.3. As you can see on the screenshot
[1], this bug causes KSensors to be useless as it is very difficult to
read the displayed values.

However, as KDE 3.3.3 has been uploaded, this package won't be in Sarge
(KDE 3.3.3 won't be in Sarge), the packages built on the autobuilders
are depending on KDE 3.3.3. 

I am therefore asking the permission to upload the version currently in 
Sid into Sarge. You can find below the diff of the source code against 
the previous revision.

Bye,
Aurelien

[1] http://people.debian.org/~aurel32/ksensors.png


--- ksensors-0.7.2.orig/ksensors/lmsensorswidget.cpp
+++ ksensors-0.7.2/ksensors/lmsensorswidget.cpp
@@ -90,10 +90,12 @@
     Sensor *sensor= sensors->getSensor(name);
     if(sensor) {
       if(Panel::readShow(name)!= (bool)panel ) {
-         if(panel) { delete panel; panel= 0; }
+         if(panel) delete panel;
          else      (void)new LMSensorPanel(sensor, this, sensor->name() );
       }
     } else infoPanels->configChanged(name);
+    
+    panel= (Panel *)child(name);
     if(panel) loadPalette(panel);
  } else {
     loadPalette();
--- ksensors-0.7.2.orig/ksensors/lmsensorpanel.cpp
+++ ksensors-0.7.2/ksensors/lmsensorpanel.cpp
@@ -51,8 +51,8 @@
      }
      switch( sensor->getTempScale() )
      {
-      case Sensor::dgKelvin: valMask= "%0.fK"; break;
-      default              : valMask= "%0.f^"; break;
+      case Sensor::dgKelvin: valMask= "%.0fK"; break;
+      default              : valMask= "%.0f^"; break;
      }
      break;
 
@@ -63,7 +63,7 @@
        arc->setValueMaxLimit( sensor->getValueMax(),0);
        arc->setColorRanges(red,green,green);
      }
-     valMask= "%0.f RPM";
+     valMask= "%.0f RPM";
      break;
 
    case Sensor::lmVoltage :
@@ -76,7 +76,7 @@
        arc->setColorRanges(blue,QColor(0,200,150),blue);
        arc->setArrowColor(darkBlue);
      }
-     valMask= "%0.2fv";
+     valMask= "%.2fv";
      break;
 
  }

-- 
  .''`.  Aurelien Jarno	              GPG: 1024D/F1BCDB73
 : :' :  Debian GNU/Linux developer | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net



Reply to: