Re: One test of brio test suite seems to run into endless loop on some hardware architectures
Hi Jim,
On Tue, Jan 19, 2021 at 10:34:28AM -0500, Jim Hester wrote:
> Looking at the code I think the issue is I was storing the results of
> `fgetc()` as a `char` and then checking if it matched `EOF`. This works on
> x86, but non-intel architectures must use a different value of `EOF` that
> doesn't fit in `char` storage.
>
> In
> https://github.com/r-lib/brio/commit/f1d6329bc6261ad72489550bc21b53ef271b5062
> I switched to using `int`, as the `fgetc()` type signature shows, so I
> believe that should fix the problem.
Sounds plausible.
> I will release a new version of brio to CRAN in the next day or two with
> this change.
Thanks a lot
Andreas.
--
http://fam-tille.de
Reply to: