Hi,
Le mer. 27 mai 2020 à 20:04, Nilesh Patra <npatra974@gmail.com> a écrit :
>
> The second test (needing the library) failed on gitlab-ci, w/o adding r-cran-xml and r-cran-runit, possible because this doesn't pick up depends from test-depends.
> This passed on my local machine though. Since I wanted to be sure, I moved this there.
There is probably a bug on the salsa-ci side, because both tests
passed on my computer. Let's skip salsa-ci for now.
Ahh, alrighty.
I have moved back these dependencies to test-deps and I have updated
your patch (str_replace_all --> gsub) to not add a new dependency.
That's good, and makes sense. I didn't know about this, possibly because I don't speak R :P
You probably already noticed, the debian/test/control files for R
packages require a lot of manual work to keep the list of test-deps
up-to-date. Because I don't want to do this manually, I moved the code
to tests these packages into pkg-r-autopkgtest. The list of test-deps
is automatically generated at run time from the DESCRIPTION file
That's nice!
Currently, it is enabled only for bioconductor packages, if there is
no big bug with this transition, we will be able to remove the
debian/test/control files and to enable this for other R packages.
Got it, thanks for the explanation.
Thanks again for #961591.
:)
And thanks a lot for letting me have this upload (i.e. my name on d/ch for this upload)
Kind regards,
Nilesh