[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFS] r-bioc-graph





On Wed, 27 May 2020, 23:28 Dylan Aïssi, <daissi@debian.org> wrote:
Hi Nilesh,

Le mer. 27 mai 2020 à 19:36, Nilesh Patra <npatra974@gmail.com> a écrit :
>
> Hi,
> Currently r-bioc-graph has failing tests, and has RC bug - #961591 filed against this.
> I have fixed this and pushed my changes to the team repo here[1].
> Need review and sponsorship.
>

Thanks for #961591 !!!

I don't understand why you moved some test-deps to deps ?

The second test (needing the library) failed on gitlab-ci, w/o adding r-cran-xml and r-cran-runit, possible because this doesn't pick up depends from test-depends.
This passed on my local machine though. Since I wanted to be sure, I moved this there.

Was this incorrect to do?
Please do let me know.

Regards,
Nilesh

Reply to: