[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Please read TODO entries in d/changelog before uploading (Was: r-cran-proc_1.16.1-1_source.changes ACCEPTED into unstable)



Hi Andreas,

On 15.01.20 11:50, Andreas Tille wrote:
Hi Steffen,

the package needs vdiffr and logcondens (in new) to pass its test suite
That is unexpected and annoying, indeed.

Failed with error:  ‘there is no package called ‘logcondens’’
══ testthat results  ═══════════════════════════════════════════════════════════
[ OK: 8150 | SKIPPED: 12 | WARNINGS: 72 | FAILED: 109 ]
1. Error: are.paired return.paired.rocs smoothes curves with the right method (@test-are-paired.R#113)
2. Error: Ggroc screenshot looks normal (@test-ggroc.R#9)
3. Error: Ggroc list screenshot looks normal (@test-ggroc.R#16)
4. Error: Ggroc list can take multiple aes (@test-ggroc.R#23)
5. Error: Ggroc list extra aestetics screenshot looks normal (@test-ggroc.R#30)
6. Error: Ggroc list with group facet screenshot looks normal (@test-ggroc.R#39)
7. Error: plot draws correctly (@test-plot.R#13)
8. Error: legacy.axis works correctly (@test-plot.R#25)
9. Error: Advanced screenshot 1 works correctly (@test-plot.R#47)
1. ...

Error: testthat unit tests failed


If you do uploads it would help to at least edit the changelog
that makes sense to some reader of an uploaded package for
instance like:

    Test suite will fail due to missing r-cran-logcondens

or so.  If I drop some TODO in d/changelog this *really* should be done
before any upload.  I've noticed that you have the habit to drop TODO
items in d/changelog.  That's IMHO a misuse of d/changelog that records
what actually has been done but not what in the future needs to be done.

Thus, please do not upload with open TODO in d/changelog.  If there
might be really things to do debian/README.source is the file where
developers are communicating about issues with the package.

What I did was to run routine-update and that just did the update. I
should have manually checked it all again, but I admittedly did not.

So, I suggest that "TODO" or (preferably from my side "BLOCKER" - since
there is always something to do) in d/changelog should possibly stop the
routine update before it sets the "unstable" in the changelog, much like
a patch failing to be applied?

Cheers,

Steffen


On Wed, Jan 15, 2020 at 10:34:41AM +0000, Debian FTP Masters wrote:


Accepted:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 15 Jan 2020 11:13:20 +0100
Source: r-cran-proc
Architecture: source
Version: 1.16.1-1
Distribution: unstable
Urgency: medium
Maintainer: Debian R Packages Maintainers <r-pkg-team@alioth-lists.debian.net>
Changed-By: Steffen Moeller <moeller@debian.org>
Changes:
  r-cran-proc (1.16.1-1) unstable; urgency=medium
  .
    [ Dylan Aïssi ]
    * Add r-cran-mass to test-deps.
    TODO: add r-cran-vdiffr (in New queue -> #948825)
          and r-cran-logcondens
              (https://salsa.debian.org/r-pkg-team/r-cran-logcondens - can't ITP any more since I reached my 5 packages per hour limit :-P)
  .
    [ Steffen Moeller ]
    * New upstream version
    * Standards-Version: 4.4.1 (routine-update)
    * Trim trailing whitespace.
    * Set upstream metadata fields: Archive, Bug-Database, Bug-Submit.
Checksums-Sha1:
  34929405d9a0d662d14ceb1af147c70664dd1b00 2120 r-cran-proc_1.16.1-1.dsc
  5a889f20b0ca9d095106da5400ba73a995061a41 371505 r-cran-proc_1.16.1.orig.tar.gz
  884891d1075c7ab07e75dad150cc3585310c1a95 2848 r-cran-proc_1.16.1-1.debian.tar.xz
  a15d28999106557bd48427631044c930fcb555a6 9063 r-cran-proc_1.16.1-1_source.buildinfo
Checksums-Sha256:
  e4c9820590bf3197ce6f0902e19f5e7e9d20d02603ffd4c341fbf41f274656db 2120 r-cran-proc_1.16.1-1.dsc
  35bd783811ba0138a1f8d6d7eecca7fc3c98f7aec62fe094ea577741fd0a7762 371505 r-cran-proc_1.16.1.orig.tar.gz
  55441e1fc7a9ace4e222749d4aa389ac75d985e5b1ba819a15aef00854370b2d 2848 r-cran-proc_1.16.1-1.debian.tar.xz
  06020dc0893354255afaa7a5f6e27cdc65b84f140393e2f034946f051735b943 9063 r-cran-proc_1.16.1-1_source.buildinfo
Files:
  16f151151a9123a6223112b5d43e31ef 2120 gnu-r optional r-cran-proc_1.16.1-1.dsc
  9b70044fb48d866973df0740eacfda81 371505 gnu-r optional r-cran-proc_1.16.1.orig.tar.gz
  5383ca4027266c1bbd65590f8792c2bf 2848 gnu-r optional r-cran-proc_1.16.1-1.debian.tar.xz
  8b53b044d87fdfedf546764619256c7f 9063 gnu-r optional r-cran-proc_1.16.1-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJHBAEBCAAxFiEEhMGXeonn7+0+XKYuL9i+2sAg7tEFAl4e5e0THG1vZWxsZXJA
ZGViaWFuLm9yZwAKCRAv2L7awCDu0fuSD/wIfOAEnKWrV4gTmP/9rG1A819t5gHD
UhLUfHMgwlTLnGZ4stCqlpZZXDv1AM8M53ZTUwY8wQFLd26kkZG74jTrSJ0aNNUA
LcPNVe8fJ84SldWkD9+90XFCsWd45OeMivhLu2r04gIAN98aqDpfSLWaWoXVwAxV
0YRfCLKyFXzLdMIA/CmSkNqtm6ZShqaY+iFv7GwInZrZIOYFNvyC1Ty+rLiCSkQj
aCi/P1mMb7Hjjt4++popsYTwKW/oCkIQ0cRQvfnjZCGeV6uV/t7e3anjAfnA99I3
IPmLFVZiVfm8H8WbbxYc/NyxwyAU5gbobLUTd2nXzGypWophFdv8lM4vbI2KNuTh
maOCbDT9hMr0wVydK6u6qlvNKcAkKGmsQxiSdx4U5ls6TXRoNCLvE/TqyapO3CLF
tmwvvPlYXvKLGQ0o2Etrdg77APjUHgGvTRxQCeiboqyz6dFFjwkXjyyxmQyF9VCf
wQZ0+TdrT0G01J9AJ0gkmdxG6oQBYROHDLdx63T6zirr/S3MQQJNSWlB2uCwTo/5
JdKpmjO58BlNoliMbiASWmWkdtqhvxogQxaapJlGPJOnF8NuKm6enXf3oJ84P+Gy
YWCxIZuualXG6TXh8EZtMWQuaSBo/cA9pWnu2FCWsyMTVrCaj0qXjM3YnJUO3+KF
HFeMwENry5Eh1g==
=w0kB
-----END PGP SIGNATURE-----


Thank you for your contribution to Debian.

_______________________________________________
R-pkg-team mailing list
R-pkg-team@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/r-pkg-team


Reply to: