[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#897026: debhelper: Debian::Debhelper::Buildsystem should not require debian/control



Hi Niels,

On Sat, Apr 28, 2018 at 07:02:00AM +0000, Niels Thykier wrote:
> I am sorry to hear that debhelper/11.2 broke dh-make-R.
> 
> It is not going to be trivial as trivial as I would like to "undo" this
> issue on the debhelper side.  I would basically have to revert the
> support for "cmake+ninja" (etc.) or lock debhelper into never using
> compat at load/"compile" time of the Buildsystem class hierarchy (which
> will require some needlessly complicated tricks and I fear it will grow
> unwieldy over time).
> 
> I have then analysed dh-make-R and it turns out that dh-make-R (and
> dh-update-R) only needs the "parse_depends" function from
> "Debian::Debhelper::Buildsystem::R".  Said function seems like it can
> easily be extracted into a separate Perl package and imported from there
> into dh-make-R, dh-update-R and "Debian::Debhelper::Buildsystem::R".
> 
>  * Would this be an option for you?

Definitely.
 
> This would avoid hacks on my side and make dh-make-R + dh-update-R less
> sensitive to "unrelated" changes to the Debhelper buildsystem ABI.

Perfectly fine.

> PS: The "use Debian::Debhelper::Buildsystem::R qw(parse_deps)" line in
> dh-make-R and dh-update-R appear to reference a non-existing an unused
> parse_deps instead of parse_depends.

I admit I'm not a Perl programmer nor did I dived deeply into the
dh-*-R code.  I'm CCing the list - patches welcome as always.

Thanks for your quick response.  Please let me know if there is anything
unreleased I could test and confirm.

Kind regards

      Andreas.

-- 
http://fam-tille.de


Reply to: