[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1004705: marked as done (qtfeedback: contains flawed auto-generated cmake config file)

Your message dated Mon, 31 Jan 2022 22:03:55 +0000
with message-id <E1nEemB-000F1F-Hd@fasolo.debian.org>
and subject line Bug#1004705: fixed in qtfeedback-opensource-src 5.0~git20180903.a14bd0b-3
has caused the Debian Bug report #1004705,
regarding qtfeedback: contains flawed auto-generated cmake config file
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1004705: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1004705
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: qtbase-opensource-src
Severity: important
Version: 5.15.2+dfsg-14
X-Debbugs-Cc: marius@ubports.com

Hi Lisandro, hi Dmitry,
I see a build issue with hfd-service, depending on qtfeedback, shipping auto-generated CMake files created from templates in qtbase-opensource-src.
The build error I get in hfd-service with a simple rebuild against current qtbase-opensource-src and qtfeedback in Debian unstable, I get this CMake error: 

```
dh binary --buildsystem cmake
   dh_update_autotools_config -O--buildsystem=cmake
   dh_autoreconf -O--buildsystem=cmake
   dh_auto_configure -O--buildsystem=cmake
cd obj-x86_64-linux-gnu && cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=None -DCMAKE_INSTALL_SYSCONFDIR=/etc -DCMAKE_INSTALL_LOCALSTATEDIR=/var -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_INSTALL_RUNSTATEDIR=/run -DCMAKE_SKIP_INSTALL_ALL_DEPENDENCY=ON "-GUnix Makefiles" -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_INSTALL_LIBDIR=lib/x86_64-linux-gnu .. 
-- The C compiler identification is GNU 11.2.0
-- The CXX compiler identification is GNU 11.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.2")
-- Checking for module 'libudev'
--   Found libudev, version 249
-- Checking for module 'android-headers'
--   No package 'android-headers' found
-- Checking for module 'libhardware'
--   No package 'libhardware' found
CMake Warning at CMakeLists.txt:22 (message):
  Bulding without libhybris support, missing required dependencies!
CMake Error at /usr/lib/x86_64-linux-gnu/cmake/Qt5Feedback/Qt5Feedback_.cmake:5 (_populate_Feedback_plugin_properties): 
  _populate_Feedback_plugin_properties Macro invoked with incorrect arguments
  for macro named: _populate_Feedback_plugin_properties
Call Stack (most recent call first):
/usr/lib/x86_64-linux-gnu/cmake/Qt5Feedback/Qt5FeedbackConfig.cmake:240 (include) 
  qt/feedback-plugin/CMakeLists.txt:4 (find_package)
-- Installing Qt5 feedback plugin to: lib/x86_64-linux-gnu/qt5/plugins/feedback 
-- Checking for module 'systemd'
--   Found systemd, version 249
-- /lib/systemd/system is the systemd system unit file install dir
-- Configuring incomplete, errors occurred!

```
After some digging, I found that the below Gentoo fix is a likely candidate to fix this backwards compatibility issue: 
https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-qt/qtcore/files/qtcore-5.14.1-cmake-macro-backward-compat.patch
Also, when I manually patch qtfeedback5-dev after installation as below before building hfd-service, I get a working build for hfd-service: 

```
[sunweaver@sunobo qtfeedback.pkg]$ diff -u /usr/lib/x86_64-linux-gnu/cmake/Qt5Feedback/Qt5FeedbackConfig.cmake /usr/lib/x86_64-linux-gnu/cmake/Qt5Feedback/Qt5FeedbackConfig.cmake.mine --- /usr/lib/x86_64-linux-gnu/cmake/Qt5Feedback/Qt5FeedbackConfig.cmake 2022-01-02 22:21:55.000000000 +0100 +++ /usr/lib/x86_64-linux-gnu/cmake/Qt5Feedback/Qt5FeedbackConfig.cmake.mine 2022-01-31 22:13:14.155658053 +0100 
@@ -223,8 +223,8 @@
file(GLOB pluginTargets "${CMAKE_CURRENT_LIST_DIR}/Qt5Feedback_*.cmake") 
     endif()
- macro(_populate_Feedback_plugin_properties Plugin Configuration PLUGIN_LOCATION 
-          IsDebugAndRelease)
+ macro(_populate_Feedback_plugin_properties Plugin Configuration PLUGIN_LOCATION) 
+        set(IsDebugAndRelease)
set_property(TARGET Qt5::${Plugin} APPEND PROPERTY IMPORTED_CONFIGURATIONS ${Configuration})
set(imported_location "${_qt5Feedback_install_prefix}/lib/x86_64-linux-gnu/qt5/plugins/${PLUGIN_LOCATION}") 
```
Can someone please take a look at the proposed Gentoo patch and fix qtbase-opensource-src in Debian unstable? That would really help with packaging Lomiri for Debian. Thanks!
If you approve the qtbase-opensource-src patch as proposed by the Gentoo maintainer, I'll be happy to upload a -15 of qtbase-opensource-src to unstable, in case that speeds up things. Thanks. 

Mike

--

DAS-NETZWERKTEAM
c\o Technik- und Ökologiezentrum Eckernförde
Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde
mobile: +49 (1520) 1976 148
landline: +49 (4351) 850 8940

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

Attachment: pgpivgD48E2G5.pgp
Description: Digitale PGP-Signatur


--- End Message ---
--- Begin Message --- 
Source: qtfeedback-opensource-src
Source-Version: 5.0~git20180903.a14bd0b-3
Done: Mike Gabriel <sunweaver@debian.org>

We believe that the bug you reported is fixed in the latest version of
qtfeedback-opensource-src, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1004705@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mike Gabriel <sunweaver@debian.org> (supplier of updated qtfeedback-opensource-src package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 31 Jan 2022 22:50:50 +0100
Source: qtfeedback-opensource-src
Architecture: source
Version: 5.0~git20180903.a14bd0b-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Mike Gabriel <sunweaver@debian.org>
Closes: 1004705
Changes:
 qtfeedback-opensource-src (5.0~git20180903.a14bd0b-3) unstable; urgency=medium
 .
   * debian/rules:
     + Remove broken CMake file (maybe needs later investigation in more depth).
       (Closes: #1004705).
Checksums-Sha1:
 be6d344aea3beeaa6286a2c5a1f68bb05deb95f3 2690 qtfeedback-opensource-src_5.0~git20180903.a14bd0b-3.dsc
 3b51658278819e0535507f8a4fcdc94fd41cb60f 9752 qtfeedback-opensource-src_5.0~git20180903.a14bd0b-3.debian.tar.xz
 359a2303ec2af9c4cb2e7ca313874d57fa354d7f 13708 qtfeedback-opensource-src_5.0~git20180903.a14bd0b-3_source.buildinfo
Checksums-Sha256:
 550dd1a79aa510fb75e15f4d084e736967da5e21d2c7bb2a0f8b30570c0ce370 2690 qtfeedback-opensource-src_5.0~git20180903.a14bd0b-3.dsc
 8f1b826178525a536a6f90b8576bbae655a6994e8457e5f68fda926b7c67a751 9752 qtfeedback-opensource-src_5.0~git20180903.a14bd0b-3.debian.tar.xz
 5fa0ba7ce937ba304b9ba178952ee485193b4e09e56134326a9bd5021a5374ca 13708 qtfeedback-opensource-src_5.0~git20180903.a14bd0b-3_source.buildinfo
Files:
 29462726c9b591e1d10b8e5fccda0b90 2690 libs optional qtfeedback-opensource-src_5.0~git20180903.a14bd0b-3.dsc
 e3d5e1dc4bc837ededb52a9260f14087 9752 libs optional qtfeedback-opensource-src_5.0~git20180903.a14bd0b-3.debian.tar.xz
 cf1ff9b1d2858e1c07d2bf9fbacaf22c 13708 libs optional qtfeedback-opensource-src_5.0~git20180903.a14bd0b-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEm/uu6GwKpf+/IgeCmvRrMCV3GzEFAmH4WkYVHHN1bndlYXZl
ckBkZWJpYW4ub3JnAAoJEJr0azAldxsxnMoQAJrYxJEmz4uBSjLZqVfx9yt/2ahS
RaAfR07M+yEY+wOohsdzbOmefk36Pbd3MKHWTNjg8VZnr/451VTBU5k11n2qp45O
xSXP+7GFX/Jftl+y6RS9mZBvmi4LOVIm5ukLKeMgpXtEojm7ieXpFI26/AT1NDXQ
aeIJdjctFe8olP/X9mztCKCyBhL+fSnmdn60RVubwrzSHD+NSIC5mDCvC1IFZRYD
i7dmTMb8gXTgozoIc2khra45pSUxPoPYKI6eGoRHwRMCMC36pSjvmZnnrEClLX8w
JBj3gGPQgvN1/6D9xuawvsL0tgYDQ5RcTg92Jp99Wkg7YVGv/Su9erAgAped6mhE
K8+FbdXpmRMKdft9RRTH+lyouPxOhDPMsGHQEWpt7Axp9Z2Mxg5pOO8OXd21Gl0K
CIYtyp7XLcppNNEqx5mobmtkGjYpEk3y6b9o73n5XOIU6AHkkMeX0S+9YADIaayu
8rtyi4RuEpt6agaipGk44iIrgF+QwxZOVwPWKteaxoIGJU19vki5AE8iLNedjmrF
GWeN9XS5FGFOaAtyiXFbjN7U/Xm38JJ8nxN/joIdPJ9MyQg4kPXen0KvG60PyD6F
hJ1eoyj6gTU1Oq6LtBnK7h/6B0/jTKScARkAhRpZ/x/ycgVDth1PmEpQnB9PKOhX
R6Sjxoh3OvZN1xda
=PwnQ
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: