Package: qtbase-opensource-src Severity: important Version: 5.15.2+dfsg-14 X-Debbugs-Cc: marius@ubports.com Hi Lisandro, hi Dmitry,I see a build issue with hfd-service, depending on qtfeedback, shipping auto-generated CMake files created from templates in qtbase-opensource-src.
The build error I get in hfd-service with a simple rebuild against current qtbase-opensource-src and qtfeedback in Debian unstable, I get this CMake error:
``` dh binary --buildsystem cmake dh_update_autotools_config -O--buildsystem=cmake dh_autoreconf -O--buildsystem=cmake dh_auto_configure -O--buildsystem=cmakecd obj-x86_64-linux-gnu && cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=None -DCMAKE_INSTALL_SYSCONFDIR=/etc -DCMAKE_INSTALL_LOCALSTATEDIR=/var -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_INSTALL_RUNSTATEDIR=/run -DCMAKE_SKIP_INSTALL_ALL_DEPENDENCY=ON "-GUnix Makefiles" -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_INSTALL_LIBDIR=lib/x86_64-linux-gnu ..
-- The C compiler identification is GNU 11.2.0 -- The CXX compiler identification is GNU 11.2.0 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: /usr/bin/cc - skipped -- Detecting C compile features -- Detecting C compile features - done -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.2") -- Checking for module 'libudev' -- Found libudev, version 249 -- Checking for module 'android-headers' -- No package 'android-headers' found -- Checking for module 'libhardware' -- No package 'libhardware' found CMake Warning at CMakeLists.txt:22 (message): Bulding without libhybris support, missing required dependencies!CMake Error at /usr/lib/x86_64-linux-gnu/cmake/Qt5Feedback/Qt5Feedback_.cmake:5 (_populate_Feedback_plugin_properties):
_populate_Feedback_plugin_properties Macro invoked with incorrect arguments for macro named: _populate_Feedback_plugin_properties Call Stack (most recent call first):/usr/lib/x86_64-linux-gnu/cmake/Qt5Feedback/Qt5FeedbackConfig.cmake:240 (include)
qt/feedback-plugin/CMakeLists.txt:4 (find_package)-- Installing Qt5 feedback plugin to: lib/x86_64-linux-gnu/qt5/plugins/feedback
-- Checking for module 'systemd' -- Found systemd, version 249 -- /lib/systemd/system is the systemd system unit file install dir -- Configuring incomplete, errors occurred! ```After some digging, I found that the below Gentoo fix is a likely candidate to fix this backwards compatibility issue:
https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-qt/qtcore/files/qtcore-5.14.1-cmake-macro-backward-compat.patchAlso, when I manually patch qtfeedback5-dev after installation as below before building hfd-service, I get a working build for hfd-service:
```[sunweaver@sunobo qtfeedback.pkg]$ diff -u /usr/lib/x86_64-linux-gnu/cmake/Qt5Feedback/Qt5FeedbackConfig.cmake /usr/lib/x86_64-linux-gnu/cmake/Qt5Feedback/Qt5FeedbackConfig.cmake.mine --- /usr/lib/x86_64-linux-gnu/cmake/Qt5Feedback/Qt5FeedbackConfig.cmake 2022-01-02 22:21:55.000000000 +0100 +++ /usr/lib/x86_64-linux-gnu/cmake/Qt5Feedback/Qt5FeedbackConfig.cmake.mine 2022-01-31 22:13:14.155658053 +0100
@@ -223,8 +223,8 @@file(GLOB pluginTargets "${CMAKE_CURRENT_LIST_DIR}/Qt5Feedback_*.cmake")
endif()
- macro(_populate_Feedback_plugin_properties Plugin Configuration
PLUGIN_LOCATION
- IsDebugAndRelease)+ macro(_populate_Feedback_plugin_properties Plugin Configuration PLUGIN_LOCATION)
+ set(IsDebugAndRelease)set_property(TARGET Qt5::${Plugin} APPEND PROPERTY IMPORTED_CONFIGURATIONS ${Configuration})
set(imported_location "${_qt5Feedback_install_prefix}/lib/x86_64-linux-gnu/qt5/plugins/${PLUGIN_LOCATION}")
```Can someone please take a look at the proposed Gentoo patch and fix qtbase-opensource-src in Debian unstable? That would really help with packaging Lomiri for Debian. Thanks!
If you approve the qtbase-opensource-src patch as proposed by the Gentoo maintainer, I'll be happy to upload a -15 of qtbase-opensource-src to unstable, in case that speeds up things. Thanks.
Mike -- DAS-NETZWERKTEAM c\o Technik- und Ökologiezentrum Eckernförde Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde mobile: +49 (1520) 1976 148 landline: +49 (4351) 850 8940 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
Attachment:
pgprKOEMs3WDo.pgp
Description: Digitale PGP-Signatur