¡Hola Boris! El 2018-09-24 a las 17:57 +0300, Boris Pek escribió:
Hi,
First of all, thanks for working in improving kde-gtk-config.
* New upstream release.
As mentioned in a private mail, I try to avoid versions were the only change is the version bump.
Yep, I remember. But there were no reason to not update this version together with package update. Also debdiff says that two lines were changed in file "po/zh_CN/kde-gtk-config.po". ;-)
Oh, I missed that, currently I'm checking the diff between upstream tags in minor versions, I guess I should probably also need to check the tarballs. :(
* Simplify debian/control: drop requirement of specific version of cmake (was >= 2.8.12), because even Debian Jessie has cmake version 3.0.2.
The CMakeLists.txt states that it requires the version, why would the debian/control show this requirement?
That was "why wouldn't/shouldn't ... also". :(
I don't see a simplification here, also the version build dependency is added by a script that parses the CMakeLists.txt shipped in the package in particular: cmake_minimum_required(VERSION 2.8.12)
Obviously we use different tools and rules during maintaining of packages. And I just was not aware of your script.
So, the version dependency would be added in the next run of the script.
I do not see a problem here. If you will add versioned dependency in a next upload, than let it be. Or you may manually edit file after automatic changes done by script. Or we may improve that magical script...
The script is currently in: https://salsa.debian.org/qt-kde-team/pkg-kde-jenkins/blob/master/hooks/prepare/cmake_update_deps WARNING, it's an ugly piece of ... code.
This is co-maintained package. We just have to come to common decision and I will add a point in my notes for this package.
Are you really that much against adding a version dependency is no longer in the archive?
This is not strictly a matter of principle, but just a question of common sense.
Ok, let's agree that common sense is subjective here, and we just want something team acceptable, maintainable.
Personally, I prefer adding the version dependency as a way of showing the upstream package requirements. That way the source package ends up being more independant of the current Debian archive, we don't need to review all the packages when some release is no longer being supported and if somebody wants to do some crazy thing with the package, well, we are not working against them.
Happy hacking, -- "If you think your users are idiots, only idiots will use it." -- Linus Torvalds Saludos /\/\ /\ >< `/
Attachment:
signature.asc
Description: PGP signature