[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#904090: expeyes: Build-depends on Qt4 toolchain



Source: expeyes
User: debian-qt-kde@lists.debian.org
Usertags: qt4-removal
X-Debbugs-CC: debian-qt-kde@lists.debian.org
Severity: normal
Tags: patch

==== mail template starts ====

Hi! As you might know we the Qt/KDE team are preparing to remove Qt4
as announced in:

[announced]
<https://lists.debian.org/debian-devel-announce/2017/08/msg00006.html>

Currently Qt4 has been dead upstream and we are starting to have problems
maintaining it.

In order to make this move, all packages directly or indirectly depending on
the Qt4 libraries have to either get ported to Qt5 or eventually get
removed from the Debian repositories.

Therefore, please take the time and:
- contact your upstream (if existing) and ask about the state of a Qt5
port of your application
- if there are no activities regarding porting, investigate whether there are
suitable alternatives for your users
- if there is a Qt5 port that is not yet packaged, consider packaging it
- if both the Qt4 and the Qt5 versions already coexist in the Debian
archives, consider removing the Qt4 version

= Porting =

Some of us where involved in various Qt4 to Qt5 migrations [migration] and we
know for sure that porting stuff from Qt4 to Qt5 is much much easier and less
painful than it was from Qt3 to Qt4.

We also understand that there is still a lot of software still using Qt4.

Don't forget to take a look at the C++ API changes page [apichanges] whenever
you start porting your application.

[migration] http://pkg-kde.alioth.debian.org/packagingqtbasedstuff.html
[apichanges] http://doc.qt.io/qt-5/sourcebreaks.html

For any questions and issues, do not hesitate to contact the Debian Qt/KDE
team at debian-qt-kde@lists.debian.org

The removal is being tracked in <https://wiki.debian.org/Qt4Removal> .

==== mail template ends ====

I noticed that your package is using Qt4 toolchain in build dependencies but
has Qt5 as runtime dependency. This often indicates that some leftover remains
for the Qt4 -> Qt5 migration and it would be great if we could fully use Qt5
toolchain.

According to https://salsa.debian.org/georgesk/expeyes/blob/a562190dff060868f92a341af2198928d36e56a0/debian/control#L9 ,
the package is using pyqt4-dev-tools and qt4-linguist-tools. Please consider
replacing them with pyqt5-dev-tools and qttools5-dev-tools.

Patch provided:

diff --git a/debian/control b/debian/control
index 821e0f1..ea94087 100644
--- a/debian/control
+++ b/debian/control
@@ -6,7 +6,7 @@ Build-Depends: debhelper (>= 10), quilt,
  python3-all, python-all, dh-python,
  gcc-avr, binutils-avr, avr-libc (>=1:1.8.0+Atmel3.5.0),
  pkg-config, libgtk2.0-dev, x11proto-randr-dev (>= 1.5.0),
- pyqt4-dev-tools, qt4-linguist-tools
+ pyqt5-dev-tools, qttools5-dev-tools
 Standards-Version: 4.1.5
 Homepage: http://expeyes.in/
 Vcs-Browser: https://salsa.debian.org/georgesk/expeyes

--
Regards,
Boyuan Yang

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: