On martes, 7 de febrero de 2017 20:21:55 ART Helmut Grohne wrote: > On Tue, Feb 07, 2017 at 02:56:33PM -0300, Lisandro Damián Nicanor Pérez Meyer wrote: > > By the description you give here I *think* you are just taking into > > account > > 32/64 bits, but that's not necessarily enough: you might have to do > > substitutions on 32 bits archs. Example: qt4's qreal on arm is a float, on > > i386 is a double. > > That's entirely correct. This approach does not make updating > substitutions go away. It only makes those cases go away that really > only depend on the number of bits. Your qreal example doesn't depend on > the bits, so it doesn't go away. This is not a full solution, but it > removes a significant chunk of updating. That may be worth it already. Ah, I missed the part that it's not a full replacement. I like the idea. > > Using compile-time definitions might not always work except you always > > build depend upon whatever defines a type. Example: qt4's qreal, once > > again. > Again, that's entirely correct. Determining the size of qreal requires > depending on qt of course. Having to depend on qt will result in > bootstrap cycles, so let's not go down that road. My suggestion was > simply short sighted. Except if we handle it with a two or three stages setup. Nowadays we have build profiles, so we can easily build stuff with a on-source table without further build dependencies to break build loops, a second upload with the required build dependencies can run regression tests and FTBFS in case something is wrong, thus marking a quick fix. Sounds wonderful, needs developer time, which I sadly lack :-( > > Am I missing something? > > No. Thank you for the attention to detail. > > Given the above, I think that the approach from my patch looks most > promising. Do you agree? I agree with the idea, but I still have to properly check it and also wait for Dmitry's input. If everything is ok this should go in once we get Stretch released. Kinds regards, Lisandro. -- Videogames do not influence kids. I mean, if Pac-Man influenced our generation, we would all be jumping in dark rooms, chomping magic pills and listening to electronic repeating music. Kristian Wilson, Nintendo Inc. 1989 Lisandro Damián Nicanor Pérez Meyer http://perezmeyer.com.ar/ http://perezmeyer.blogspot.com/
Attachment:
signature.asc
Description: This is a digitally signed message part.