[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#854493: pkgkde-symbolshelper: support new 64bit architectures such as tilegx, mips64r6, mips64r6el, riscv64, etc. generically



On martes, 7 de febrero de 2017 18:38:13 ART Helmut Grohne wrote:
> Package: pkg-kde-tools
> Version: 0.15.24
> Tags: patch
> User: helmutg@debian.org
> Usertags: rebootstrap
> 
> While bootstrapping tilegx, I noticed that the symbols helper keeps a
> mapping from architecture names to sizes that needs updating for every
> single new architecture. That's sad, because it is busywork added to the
> bootstrap process. Rather than extending the patterns, let me propose
> fixing part of the issue generically. A number of the patterns
> essentially distinguish 32bit architectures from 64bit architectures.
> Rather than keeping such a list here, we can reuse an existing list from
> dpkg and thus eliminate the need for updating. That's what the attached
> patch does. It might not be the best perl style, but that's about as
> much perl as I know and it actually works.

By the description you give here I *think* you are just taking into account 
32/64 bits, but that's not necessarily enough: you might have to do 
substitutions on 32 bits archs. Example: qt4's qreal on arm is a float, on 
i386 is a double.

Using compile-time definitions might not always work except you always build 
depend upon whatever defines a type. Example: qt4's qreal, once again.

Am I missing something?

-- 
Tiempo para el tiempo y un rato mas.
  Profecías, Vox Dei, basado en Eclesiastes 3:1-9

Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: