Hi Adam, On Sat, 21 Feb 2015 00:01:20 +0100, Adam Borowski wrote: > Sure. The patch appears to be too small to be copyrightable, but anyway, I > hereby grant the right to use it under any license of your choice. Thanks! I will forward it (the Q_OS_WIN vs Q_OS_WINDOWS change doesn't really matter, it was a typo in my commit which got fixed later). A couple of questions though: > // NOTE: This should match the logic in qv4targetplatform_p.h! Did you check if there should be a similar change in qv4targetplatform_p.h? That file uses WebKit-style macros, but the list of allowed platforms is the same. > I tried to check the patch against the packages in experimental, but one of > dependencies (qtxmlpatterns) failed to build for me, for reasons that don't > seem to be arch-dependent: I uploaded qtxmlpatterns 5.4.1 to experimental yesterday, and it built fine on x32 according to buildd.debian-ports.org status page. Can you please test that qtdeclarative with your patch builds/works? Please CC me when you reply, -- Dmitry Shachnev
Attachment:
signature.asc
Description: OpenPGP digital signature