tag 719064 pending thanks On Friday 13 September 2013 09:47:54 Boris Pek wrote: > control: tags 719064 + patch > > Hi, > > >> Please read the whole discussion about this patch: > >> https://codereview.qt-project.org/#change,64283 > >> https://codereview.qt-project.org/#patch,all_unified,64283,1 > >> > >> Upstream does not have objections about this (trivial) patch itself. > >> (This > >> is just a revert of destructive commit which was done earlier.) Upstream > >> only calls for more detailed commit message. > >> > >> So why do we need to wait until this commit message will be rewritten? > > > > Because if I apply the patch and it causes problems, I need to go to > > upstream. And then upstream will tell me "this patch hasn't been accepted > > yet, you are on yourself". That's the reason. > > I understand how this rule is useful in common practice. But not in this > specific case. Sorry Boris, you are not the one to make that decision. That's upon us the maintainers. Pushing it further doesn't really helps you. [snip] > https://qt.gitorious.org/qt/qt/commit/0c03af0 Now things are different :) -- Lisandro Damián Nicanor Pérez Meyer http://perezmeyer.com.ar/ http://perezmeyer.blogspot.com/
Attachment:
signature.asc
Description: This is a digitally signed message part.