[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#719064: qt4-x11: keyboard shortcuts don't work in multi-language mode



tag 719064 - patch
thanks

On Wednesday 11 September 2013 20:47:38 Boris Pek wrote:
> control: tags 719064 + patch
> 
> Hi,
> 
> > As long as upstream does not ACK the patches we will not apply them in
> > Debian. Looking at https://codereview.qt-project.org/#change,64283 it
> > seems that the patch has been not accepted.
> > 
> > If you are interested in this fix, please work with upstream to solve it.
> > I
> > will happily apply it once upstream positively acknowledges it.
> 
> Please read the whole discussion about this patch:
> https://codereview.qt-project.org/#change,64283
> https://codereview.qt-project.org/#patch,all_unified,64283,1
> 
> Upstream does not have objections about this (trivial) patch itself. (This
> is just a revert of destructive commit which was done earlier.) Upstream
> only calls for more detailed commit message.
> 
> So why do we need to wait until this commit message will be rewritten?

Because if I apply the patch and it causes problems, I need to go to upstream. 
And then upstream will tell me "this patch hasn't been accepted yet, you are 
on yourself". That's the reason.
 
> > On the other hand, we the Debian Qt/KDE team do not want people not listed
> > in Uploaders pushing stuff to our repos, except if a team member
> > explicitely allows it. Moreover, we try to avoid topic branches for fixes
> > like this. Next time please attach a patch.
> > 
> > I have just deleted the branch in the repo.
> 
> Ok. See attachment.

ACK, but please don't override a maintainer decision without asking first. 
This same patch has not been accepted upstream yet, so we don't have an 
available patch yet. I'm thus unttaging the bug as with available patch.

Kinds regards, Lisandro.

-- 

Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: