[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://phonon/{phonon-backend-null.templates}



Modestas Vainius wrote:
>>> + [...] The following Phonon
>>> + backend packages seem to be available for this system at the moment:
>>
>> As long as we can trust the detection (what does this depend on?)
> 
> phonon-backends provide 'phonon-backend' virtual package.

Yes, and I don't see any non-free or i386-only or experimental
candidates - you're guaranteed a reliable list, with only the
"recommended" package ever likely to vary.  That's why I went on to
take out the phrasing about needing to "detect" the ones that "seem to
be available for this system at the moment".
 
>>     To restore full Phonon multimedia capabilities, install one of the
>> Phonon back-end packages which are currently available for this system:
> 
> phonon-backend-null is a backend as well. I would like to see the word "real" 
> in this sentence.

My patch had "no real Phonon back-end" earlier, but okay, it wouldn't
hurt to add it here too.  Or maybe one of the two mentions should make
it more explicit that it's "unreal" in the sense of being a "dummy".

Oh, and I notice I missed a s/backend/back-end/, and I said "Qt
multimedia framework for KDE" when everywhere else it's "Qt 4" and
desktop-neutral (does the version number matter?  Are we ever
expecting to see a Qt 5?):

 _Description: Missing back-end for Phonon
  Applications using Phonon (the Qt 4 multimedia framework) will produce
  no audio or video output, because only a dummy Phonon back-end is
  installed on this system. This is typically an unintended configuration.
  .
  To restore full Phonon multimedia capabilities, install one of the real
  Phonon back-end packages which are currently available for this system:
  .
  ${recommended_backend} (recommended)${other_backends}
 
>> s/behaviour/behavior/
> 
> Are we using American English in Debian?

You're under no obligation to fake the accent, we've just chosen
standardization rather than standardisation for these reviews...

[PS:]
> E: phonon: description-starts-with-package-name

I'm not sure why it's worse to *start* with the packagename than just
to redundantly *include* it within the description (personally I'm
more annoyed by all those package synopses that just describe package
foo as "The GNU version of foo").  But yes, maybe we should consider
changing all of them to something more purely descriptive like "Qt 4
multimedia framework".  I'll put that in my new patch too. 

Note that this version changes libphononexperimental-dev's description
from

 development files for the Phonon-Experimental library

to

 Qt 4 multimedia framework - experimental development files

This may be distorting things too far - is there a better way of
accommodating the Phonon-Experimental library within this format?
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
Template: phonon-backend-null/isnt_functional_title
Type: title
_Description: Warning: Phonon is not functional

Template: phonon-backend-null/isnt_functional
Type: note
#flag:comment:4
# Translators: do not translate variable names
# only translate "(recommended)" (the one in parenthesis)
_Description: Missing back-end for Phonon
 Applications using Phonon (the Qt 4 multimedia framework) will produce
 no audio or video output, because only a dummy Phonon back-end is
 installed on this system. This is typically an unintended configuration.
 .
 To restore full Phonon multimedia capabilities, install one of the real
 Phonon back-end packages which are currently available for this system:
 .
 ${recommended_backend} (recommended)${other_backends}
Source: phonon
Section: sound
Priority: optional
Maintainer: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Uploaders: Modestas Vainius <modax@debian.org>, Fathi Boudra <fabo@debian.org>
Build-Depends: cdbs (>= 0.4.51), debhelper (>= 7.4.13), cmake (>= 2.6.2),
 pkg-kde-tools (>= 0.11), dpkg-dev (>= 1.15.5), automoc, libglib2.0-dev,
 libpulse-dev (>= 0.9.21), libqt4-dev (>= 4.5)
Standards-Version: 3.9.1
Homepage: http://phonon.kde.org/
Vcs-Browser: http://git.debian.org/?p=pkg-kde/kde-req/phonon.git
Vcs-Git: git://git.debian.org/pkg-kde/kde-req/phonon.git

Package: phonon
Architecture: all
Depends: ${misc:Depends}, libphonon4 (>= ${source:Version}),
 ${phonon:Recommended-Backend} | phonon-backend
Suggests: ${phonon:Recommended-Backend}, phonon-backend-gstreamer,
 phonon-backend-xine, phonon-backend-mplayer
Description: Qt 4 multimedia framework - metapackage
 Phonon is the Qt 4 multimedia API, which provides a task-oriented abstraction
 layer for capturing, mixing, processing, and playing audio and video content.
 .
 This metapackage ensures that the system has a working Phonon configuration
 installed (the core library and at least one back-end).

Package: libphonon-dev
Architecture: any
Section: libdevel
Depends: ${misc:Depends}, libphonon4 (= ${binary:Version}),
 ${sameVersionDep:libqt4-dev:libphonon4}, phonon-backend-null | phonon
Description: Qt 4 multimedia framework - development files
 Phonon is the Qt 4 multimedia API, which provides a task-oriented abstraction
 layer for capturing, mixing, processing, and playing audio and video content.
 .
 This package contains the development files needed to build Qt 4 applications
 using the Phonon cross-platform multimedia framework.

Package: libphonon4
Architecture: any
Section: libs
Depends: ${shlibs:Depends}, ${misc:Depends}
Breaks: phonon-backend-xine (<< 4:4.6.0really4.3.80)
Description: Qt 4 multimedia framework - core library
 Phonon is the Qt 4 multimedia API, which provides a task-oriented abstraction
 layer for capturing, mixing, processing, and playing audio and video content.
 .
 This package contains the core library of the Phonon cross-platform multimedia
 framework for Qt 4. It is required to run applications that use Phonon.

Package: libphononexperimental-dev
Architecture: any
Section: libdevel
Depends: ${misc:Depends}, libphononexperimental4 (= ${binary:Version}),
 ${sameVersionDep:libqt4-dev:libphononexperimental4}
Replaces: libphonon-dev (<< 4:4.6.0really4.4.4)
Breaks: libphonon-dev (<< 4:4.6.0really4.4.4)
Description: Qt 4 multimedia framework - experimental development files
 Phonon is the Qt 4 multimedia API, which provides a task-oriented abstraction
 layer for capturing, mixing, processing, and playing audio and video content.
 .
 This package contains the development files needed to build Phonon back-ends
 or internal applications which need the Phonon-Experimental library.
 Third-party applications should not depend on this library. Please read
 README.Debian if you are considering a build-dependency on this package.

Package: libphononexperimental4
Architecture: any
Section: libs
Depends: ${shlibs:Depends}, ${misc:Depends}
Replaces: libphonon4 (<< 4:4.6.0really4.3.80)
Breaks: libphonon4 (<< 4:4.6.0really4.3.80)
Description: Qt 4 multimedia framework - experimental library (internal)
 Phonon is the Qt 4 multimedia API, which provides a task-oriented abstraction
 layer for capturing, mixing, processing, and playing audio and video content.
 .
 This package contains the Phonon-Experimental library, which might be needed
 by Phonon back-ends or other internal applications. Third-party applications
 should not depend on this library. Please read README.Debian before using this
 library.

Package: phonon-backend-null
Architecture: all
Provides: phonon-backend
Depends: libphonon4, ${misc:Depends}
Conflicts: phonon-backend
Description: Qt 4 multimedia framework - null back-end (no real back-end)
 Phonon is the Qt 4 multimedia API, which provides a task-oriented abstraction
 layer for capturing, mixing, processing, and playing audio and video content.
 .
 This package does not provide any real Phonon back-end. It can be used to
 disable Phonon audio/video capabilities. Please note that Phonon behavior
 with this package installed has not been well tested.

Package: phonon-dbg
Priority: extra
Architecture: any
Section: debug
Depends: ${misc:Depends}, libphonon4 (= ${binary:Version})
Suggests: libphononexperimental4 (= ${binary:Version})
Description: Qt 4 multimedia framework - debugging symbols
 Phonon is the Qt 4 multimedia API, which provides a task-oriented abstraction
 layer for capturing, mixing, processing, and playing audio and video content.
 .
 This package contains debugging symbols for the Phonon library and its main
 back-ends. Install it if you want to report a crash or debug a problem with
 Phonon or its back-ends.
diff -ru phonon-4.6.0really4.4.4.pristine//debian/control phonon-4.6.0really4.4.4/debian/control
--- phonon-4.6.0really4.4.4.pristine//debian/control	2011-03-11 11:46:28.000000000 +0000
+++ phonon-4.6.0really4.4.4/debian/control	2011-03-27 12:39:05.409258946 +0100
@@ -17,36 +17,36 @@
  ${phonon:Recommended-Backend} | phonon-backend
 Suggests: ${phonon:Recommended-Backend}, phonon-backend-gstreamer,
  phonon-backend-xine, phonon-backend-mplayer
-Description: metapackage for the Phonon multimedia framework
+Description: Qt 4 multimedia framework - metapackage
  Phonon is the Qt 4 multimedia API, which provides a task-oriented abstraction
  layer for capturing, mixing, processing, and playing audio and video content.
  .
- This metapackage ensures that a user has working Phonon configuration
- installed on the system (the core library and at least one backend).
+ This metapackage ensures that the system has a working Phonon configuration
+ installed (the core library and at least one back-end).
 
 Package: libphonon-dev
 Architecture: any
 Section: libdevel
 Depends: ${misc:Depends}, libphonon4 (= ${binary:Version}),
  ${sameVersionDep:libqt4-dev:libphonon4}, phonon-backend-null | phonon
-Description: development files for the Phonon multimedia framework
+Description: Qt 4 multimedia framework - development files
  Phonon is the Qt 4 multimedia API, which provides a task-oriented abstraction
  layer for capturing, mixing, processing, and playing audio and video content.
  .
  This package contains the development files needed to build Qt 4 applications
- using Phonon cross-platform multimedia framework.
+ using the Phonon cross-platform multimedia framework.
 
 Package: libphonon4
 Architecture: any
 Section: libs
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Breaks: phonon-backend-xine (<< 4:4.6.0really4.3.80)
-Description: the core library of the Phonon multimedia framework
+Description: Qt 4 multimedia framework - core library
  Phonon is the Qt 4 multimedia API, which provides a task-oriented abstraction
  layer for capturing, mixing, processing, and playing audio and video content.
  .
  This package contains the core library of the Phonon cross-platform multimedia
- framework for Qt 4.  It is required to run applications that use Phonon.
+ framework for Qt 4. It is required to run applications that use Phonon.
 
 Package: libphononexperimental-dev
 Architecture: any
@@ -55,14 +55,14 @@
  ${sameVersionDep:libqt4-dev:libphononexperimental4}
 Replaces: libphonon-dev (<< 4:4.6.0really4.4.4)
 Breaks: libphonon-dev (<< 4:4.6.0really4.4.4)
-Description: development files for the Phonon-Experimental library
+Description: Qt 4 multimedia framework - experimental development files
  Phonon is the Qt 4 multimedia API, which provides a task-oriented abstraction
  layer for capturing, mixing, processing, and playing audio and video content.
  .
- This package contains the development files needed to build Phonon backends or
- internal applications which need the Phonon-Experimental library. Third party
- applications should not depend on this library. Please read README.Debian if
- you consider to Build-Depend on this package.
+ This package contains the development files needed to build Phonon back-ends
+ or internal applications which need the Phonon-Experimental library.
+ Third-party applications should not depend on this library. Please read
+ README.Debian if you are considering a build-dependency on this package.
 
 Package: libphononexperimental4
 Architecture: any
@@ -70,12 +70,12 @@
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Replaces: libphonon4 (<< 4:4.6.0really4.3.80)
 Breaks: libphonon4 (<< 4:4.6.0really4.3.80)
-Description: the Phonon Experimental library (internal)
+Description: Qt 4 multimedia framework - experimental library (internal)
  Phonon is the Qt 4 multimedia API, which provides a task-oriented abstraction
  layer for capturing, mixing, processing, and playing audio and video content.
  .
- This package contains the Phonon-Experimental library which might be needed by
- Phonon backends or other internal applications. Third party applications
+ This package contains the Phonon-Experimental library, which might be needed
+ by Phonon back-ends or other internal applications. Third-party applications
  should not depend on this library. Please read README.Debian before using this
  library.
 
@@ -84,12 +84,12 @@
 Provides: phonon-backend
 Depends: libphonon4, ${misc:Depends}
 Conflicts: phonon-backend
-Description: Phonon null backend (no real backend)
+Description: Qt 4 multimedia framework - null back-end (no real back-end)
  Phonon is the Qt 4 multimedia API, which provides a task-oriented abstraction
  layer for capturing, mixing, processing, and playing audio and video content.
  .
- This package does not provide any real Phonon backend. It can be used to
- disable Phonon audio/video capabilities. Please note that Phonon behaviour 
+ This package does not provide any real Phonon back-end. It can be used to
+ disable Phonon audio/video capabilities. Please note that Phonon behavior
  with this package installed has not been well tested.
 
 Package: phonon-dbg
@@ -98,10 +98,10 @@
 Section: debug
 Depends: ${misc:Depends}, libphonon4 (= ${binary:Version})
 Suggests: libphononexperimental4 (= ${binary:Version})
-Description: Phonon debugging symbols
+Description: Qt 4 multimedia framework - debugging symbols
  Phonon is the Qt 4 multimedia API, which provides a task-oriented abstraction
  layer for capturing, mixing, processing, and playing audio and video content.
  .
- This package contains debugging symbols of the Phonon library and main
- backends You should install this package when you are about to report a crash
- or want to debug a problem with Phonon or its backends.
+ This package contains debugging symbols for the Phonon library and its main
+ back-ends. Install it if you want to report a crash or debug a problem with
+ Phonon or its back-ends.
diff -ru phonon-4.6.0really4.4.4.pristine//debian/phonon-backend-null.templates phonon-4.6.0really4.4.4/debian/phonon-backend-null.templates
--- phonon-4.6.0really4.4.4.pristine//debian/phonon-backend-null.templates	2011-03-05 02:05:10.000000000 +0000
+++ phonon-4.6.0really4.4.4/debian/phonon-backend-null.templates	2011-03-27 12:22:29.565258916 +0100
@@ -4,14 +4,15 @@
 
 Template: phonon-backend-null/isnt_functional
 Type: note
-_Description: Phonon multimedia capabilities are disabled
- Phonon based (i.e. most KDE and some Qt) applications will produce no audio or
- video output because there is no real Phonon backend installed on your system.
- Typically, this is an undesirable configuration which you might have gotten to
- unintentionally.
+#flag:comment:4
+# Translators: do not translate variable names
+# only translate "(recommended)" (the one in parenthesis)
+_Description: Missing back-end for Phonon
+ Applications using Phonon (the Qt multimedia framework for KDE) will produce
+ no audio or video output, because only a dummy Phonon back-end is installed
+ on this system. This is typically an unintended configuration.
  .
- If you wish to restore full Phonon multimedia capabilities, install a real
- Phonon backend with your favourite package manager. The following Phonon
- backend packages seem to be available for your system at the moment:
+ To restore full Phonon multimedia capabilities, install one of the real
+ Phonon back-end packages which are currently available for this system:
  .
  ${recommended_backend} (recommended)${other_backends}

Reply to: