[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#451046: marked as done (qt4-x11 makes inconsistent use of floats and doubles)

Your message dated Fri, 18 Jul 2008 01:01:53 +0200
with message-id <200807180101.54622.Sune@vuorela.dk>
and subject line qt4-x11 makes inconsistent use of floats and doubles
has caused the Debian Bug report #451046,
regarding qt4-x11 makes inconsistent use of floats and doubles
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
451046: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=451046
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: qt4-x11
Version: 4.3.2-1
Severity: important
Tags: patch

When investigating the build failure of ktoon on mips/mipsel/arm
I found it comes down to two problems in qt4-x11:

a) It mis-assumes that non-IRIX MIPS systems generally have no FPU.
   The appended patch fixes that.

b) For ARM and MIPS it defines qreal as a float, which confusingly
   means isDouble() returns a float value. But other parts of the
   package, as well as users of qt4-x11, continue to use double types
   instead of qreal, which leads to data type mismatches, and eventual
   build failures.

Unless the intent is to outlaw the use of "double" or "float" for all
uses of qt4-x11 I regard this feature as inherently broken.

I'm also dubious about the performance gain achieved by this hack, I
CC debian-arm for more insight into this.


Thiemo


--- qt4-x11-4.3.2/src/corelib/global/qglobal.h.old	2007-11-10 18:17:21.000000000 +0000
+++ qt4-x11-4.3.2/src/corelib/global/qglobal.h	2007-11-10 18:18:21.000000000 +0000
@@ -840,7 +840,7 @@ QT_BEGIN_HEADER
 
 typedef int QNoImplicitBoolCast;
 
-#if defined(QT_ARCH_ARM) || (defined(QT_ARCH_MIPS) && !defined(Q_OS_IRIX))
+#if defined(QT_ARCH_ARM)
 #define QT_NO_FPU
 #endif

--- End Message ---
--- Begin Message --- 
Version: 4.4.0~rc1-1

This is fixed upstreams some time ago. Marking as such.

/Sune
-- 
Do you know how could I do for unmounting a monitor from DOS?

You must get access over the 2D tool in order to install on the microkernel.

Attachment: signature.asc
Description: This is a digitally signed message part.


--- End Message ---
Reply to: