[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#249784: kdm: Patch for SE/Linux 2.6 Security enhancements



On Sat, 3 Mar 2007 00:19:30 +0000, Luke Kenneth Casson Leighton
<lkcl@lkcl.net> said:  

>  kdm, wdm and xdm and gdm _all_ are _incredibly_ similar - it's as
>  if they were all derived from the same codebase at some time
>  (hmmm...)

>  they all have near-identical user authentication, and it's pretty
>  obvious, when you look at the right sections, exactly what needs to
>  be done.

>  in fact, without _fully_ understanding the implications, i simply
>  cut/paste the code from wdm to create the kdm patch, and the reason
>  it was rejected was because the original wdm selinux code had an
>  obscure error-case _tiny_ memory leak.

>  i mean, how _utterly_ pathetic and small-minded is that.

>  a thirty line patch i think it was, where the area was abundantly
>  obvious that you change one if statement around, and the guy
>  couldn't be bothered to fix it, after contacting me _months_ -
>  nearly a _year_
>  - after i'd stopped doing selinux and kdm development and would
>    have to
>  take _days_ to recreate the environment and he could have taken a
>  _few_ minutes of his "precious" time to fix it.

>  really i was not in the slightest bit interested in pursuing the
>  matter further.

        I did the original xdm patch back in 2003 or so, and have
 since worked on patching several other packages for SELinux, so I do
 know the domain.

        I gave downloaded the latest sources, and will work out an
 updated patch as soon as I get the darned GR vote going.

        I'll even help answering upstream questions to get it pushed
 upstream.

        manoj
-- 
I hope I'm not getting so famous that I can't think out load [sic]
anymore. Larry Wall in <199709032332.QAA21669@wall.org>
Manoj Srivastava <srivasta@debian.org> <http://www.debian.org/~srivasta/>
1024D/BF24424C print 4966 F272 D093 B493 410B  924B 21BA DABB BF24 424C



Reply to: