[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#289080: kdebase: Icons get rearranged on login



Package: kdebase
Version: 4:3.3.1-4.1
Severity: wishlist


Hi,
on Dec, 29 Martin Koller commited a patch to CVS to resolve
http://bugs.kde.org/show_bug.cgi?id=91575. I tested it today and it
seems to work with no site effects.
Please applay the Patch

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (900, 'unstable'), (400, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.9-1-686
Locale: LANG=de_DE@euro, LC_CTYPE=de_DE@euro (charmap=ISO-8859-15)

Versions of packages kdebase depends on:
ii  kappfinder                   4:3.3.1-4 KDE Application Finder
ii  kate                         4:3.3.1-4 KDE Advanced Text Editor
ii  kcontrol                     4:3.3.1-4 KDE Control Center
ii  kdebase-bin                  4:3.3.1-4 KDE Base (binaries)
ii  kdebase-data                 4:3.3.1-4 KDE Base (shared data)
ii  kdebase-kio-plugins          4:3.3.1-4 KDE I/O Slaves
ii  kdepasswd                    4:3.3.1-4 KDE password changer
ii  kdeprint                     4:3.3.1-4 KDE Print
ii  kdesktop                     4:3.3.1-4 KDE Desktop
ii  kfind                        4:3.3.1-4 KDE File Find Utility
ii  khelpcenter                  4:3.3.1-4 KDE Help Center
ii  kicker                       4:3.3.1-4 KDE Desktop Panel
ii  klipper                      4:3.3.1-4 KDE Clipboard
ii  kmenuedit                    4:3.3.1-4 KDE Menu Editor
ii  konqueror                    4:3.3.1-4 KDE's advanced File Manager, Web B
ii  konqueror-nsplugins          4:3.3.1-4 Netscape plugin support for Konque
ii  konsole                      4:3.3.1-4 KDE X terminal emulator
ii  kpager                       4:3.3.1-4 KDE Desktop Pager
ii  kpersonalizer                4:3.3.1-4 KDE Personalizer
ii  ksmserver                    4:3.3.1-4 KDE Session Manager
ii  ksplash                      4:3.3.1-4 KDE Splash Screen
ii  ksysguard                    4:3.3.1-4 KDE System Guard
ii  ktip                         4:3.3.1-4 Kandalf's Useful Tips
ii  kwin                         4:3.3.1-4 KDE Window Manager
ii  libkonq4                     4:3.3.1-4 Core libraries for KDE's file mana

-- no debconf information
--- kdiconview.cc.orig	2005-01-07 00:47:08.000000000 +0100
+++ kdiconview.cc	2005-01-07 00:53:54.000000000 +0100
@@ -872,6 +872,8 @@
 
 void KDIconView::slotNewItems( const KFileItemList & entries )
 {
+  bool firstRun = (count() == 0);  // no icons yet, this seems to be the initial loading
+
   // delay updates until all new items have been created
   setUpdatesEnabled( false );
   QRect area = iconArea();
@@ -942,7 +944,7 @@
 
         QRect oldPos = fileIVI->rect();
         fileIVI->move( x, y );
-        if ( !isFreePosition( fileIVI ) ) // if we can't put it there, then let QIconView decide
+        if ( !firstRun && !isFreePosition( fileIVI ) ) // if we can't put it there, then let QIconView decide
         {
             kdDebug(1214)<<"slotNewItems() pos was not free :-("<<endl;
             fileIVI->move( oldPos.x(), oldPos.y() );
@@ -1269,8 +1271,11 @@
         setLastIconPosition( e->pos() );
         KonqIconViewWidget::contentsDropEvent( e );
     }
-    if (QIconDrag::canDecode(e))
+    if (QIconDrag::canDecode(e)) {
       emit iconMoved();
+      if ( !m_autoAlign )    // if autoAlign, positions were saved in lineupIcons
+        saveIconPositions();
+    }
 }
 
 // don't scroll when someone uses his nifty mouse wheel

Reply to: