[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#265865: this bug _is_verry_reproducible_!



tags 265865 - unreproducible
tags 265865 + patch
retitle 265865 kdm doesn't use common modular Xsession from xfree86-common
thanks

Hi

KDM doesn't call /etc/X11/Xsession after doing kdm specific
stuff. This leads to substle breakage, because kdm's Xsession
does mostly the same stuff (loading ~/.Xresources and invoking
~/.Xsession for example) as xfree86-commons (but
/etc/X11/Xsession.options has no effect obviously).

KDM should really invoke /etc/X11/Xsession, I verified this
to work:

--- /tmp/kdmrc	2004-09-08 23:57:00.000000000 +0200
+++ /etc/kde3/kdm/kdmrc	2004-09-08 23:50:47.000000000 +0200
@@ -16,7 +16,7 @@
 AutoReLogin=false
 ClientLogFile=.xsession-errors-%s
 Reset=/etc/kde3/kdm/Xreset
-Session=/etc/kde3/kdm/Xsession
+Session=/etc/X11/Xsession
 Setup=/etc/kde3/kdm/Xsetup
 Startup=/etc/kde3/kdm/Xstartup


Sourcing ~/.*profile could be integrated in the default
Xsession.d/ provided by xfree86-common, I'm doing this in my
~/.xsession for ages but probably everybody wants this done
anyway. Considering that the "breaks with tcsh" bugs might be
related to exactly this part of the script, maybe it's trying to
be a bit too clever here. Thus there should be a Xsession.option
setting to turn it off.

Further KDMs Xsession tries to start xterm on failsafe, which is
wrong, it should start x-terminal-emulator. This is done right
by the xfree86-common Xsession script.

What it boils down to:
- using xfree86-common Xsession releaves you of some work.
- if you really want additional functionality, you can still do
  it (before calling the other Xsession or by getting it added
  to xfree86-common as a Xsession.d/* script).

HTH, 2ri
-- 
Securine email, spread GPG, clearsign all mail. http://www.gnupg.org
.
Today is the tomorrow you worried about yesterday.

Attachment: signature.asc
Description: Digital signature


Reply to: