[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#966649: Request for feedback on upload_history re-implementation



Hi Andreas!

You noticed that the date column was an integer. That's fixed now; if you update from git, and if you delete upload_history.sqlite on your machine, and re-run the tool, the upload_history column will use a datetime for the date column. It won't do many HTTP queries, so it's peaceful to do that. (In case you're curious, the integer was "epoch time", seconds since Jan 1 1970.) More info here: https://github.com/paulproteus/debian-devel-changes-history-extractor/issues/5

You noticed I'm storing message_id in the upload_history table. It's that I probably don't need that. I'll see if I can get rid of it. For now, my advice is to ignore it; I'll work on getting rid of it.

You also noticed I'm storing the full changelog paragraph. I removed that a moment ago -- if you get a fresh copy from git, it should be gone. You're right that I was storing it for debugging reasons, and I don't need it in upload_history.

As for signed_by* -- working on it next.

Thanks!

Reply to: