[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#879280: marked as done (fakeupstream.cgi: Use a 5xx HTTP status code in case of error)

Your message dated Tue, 24 Oct 2017 22:22:03 +0000
with message-id <E1e77aF-0001VC-AV@moszumanska.debian.org>
and subject line qa.debian.org bug fixed in revision 3660
has caused the Debian Bug report #879280,
regarding fakeupstream.cgi: Use a 5xx HTTP status code in case of error
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
879280: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=879280
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: qa.debian.org
Tags: patch

Dear fakeupstream.cgi maintainers,
HTTP calls to fakeupstream.cgi should return a 5xx HTTP status code in case an error occurred while processing the request.
Luckily there is already in the code a single point of exit for all errors. The following patch implements returning a 500 code in case of error.
Bikeshedding time! :) I used a "500 Internal Server Error" status code. "400 Bad Request" would also be OK. Actually every status code in the 4xx and 5xx range would be better than the current "200 OK". 

Regards,

--- fakeupstream.cgi.orig	2017-10-21 14:24:26.493174836 +0200
+++ fakeupstream.cgi	2017-10-21 15:25:01.940837493 +0200
@@ -71,7 +71,7 @@
 {
 	chdir( "/" ); # for removal of vcs_tempdir
 	my $message = shift;
-	print $q->header( "text/plain" );
+	print $q->header( "text/plain", "500 Internal Server Error" );
 	print "$message\n";
 	exit 0;
 }

--
Gioele Barabucci <gioele@svario.it>

--- End Message ---
--- Begin Message --- 
Version: 3660

This bug was closed by Mattia Rizzolo (mattia) in SVN revision 3660.
Note that it might take some time until the qa.debian.org code has
been updated and cronjobs have picked up changed data.

Commit message:

fakeupstream: return 500 in case or errors.  (Closes: #879280)

--- End Message ---
Reply to: